Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog icon / favicon #353

Closed
ErisDS opened this issue Aug 7, 2013 · 6 comments
Closed

Blog icon / favicon #353

ErisDS opened this issue Aug 7, 2013 · 6 comments
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Aug 7, 2013

Now that we have the ability for a user to upload their blog icon or favicon, we should use it in the case that it has been uploaded instead of the default Ghost one.

I believe this should be used both on the frontend and on the admin panel @JohnONolan to confirm?

We should probably also implement validation / size restriction for the upload.

@JohnONolan
Copy link
Member

Yep

@JohnONolan
Copy link
Member

Actually, I'm going re-neg on this and say we should keep a consistent Ghost-branded favicon on admin.

@ErisDS
Copy link
Member Author

ErisDS commented Aug 10, 2013

I'm not sure what the different browsers do, but favicons seem to get pretty heavily cached and so I'm concerned about how this would work in practice. Anyone know what the rules are?

@JohnONolan
Copy link
Member

Might be easier to just try it and see what happens

@matthojo
Copy link
Contributor

All experiences with fav icons for me have been that the browser will cache whatever it hits first. This is then only replaced when the cache is cleared.
You can force a favicon change with URL parameters. E.g.

<link rel="shortcut icon" href="images/favicon.ico?v=2" />

I haven't tested this recently though, so it might have changed.

@ErisDS
Copy link
Member Author

ErisDS commented Sep 6, 2013

we are killing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants