-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog icon / favicon #353
Comments
Yep |
Actually, I'm going re-neg on this and say we should keep a consistent Ghost-branded favicon on admin. |
I'm not sure what the different browsers do, but favicons seem to get pretty heavily cached and so I'm concerned about how this would work in practice. Anyone know what the rules are? |
Might be easier to just try it and see what happens |
All experiences with fav icons for me have been that the browser will cache whatever it hits first. This is then only replaced when the cache is cleared.
I haven't tested this recently though, so it might have changed. |
we are killing this for now |
Now that we have the ability for a user to upload their blog icon or favicon, we should use it in the case that it has been uploaded instead of the default Ghost one.
I believe this should be used both on the frontend and on the admin panel @JohnONolan to confirm?
We should probably also implement validation / size restriction for the upload.
The text was updated successfully, but these errors were encountered: