Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content management screen loading takes too long #395

Closed
JohnONolan opened this issue Aug 12, 2013 · 12 comments
Closed

Content management screen loading takes too long #395

JohnONolan opened this issue Aug 12, 2013 · 12 comments

Comments

@JohnONolan
Copy link
Member

When running a deployed instance of Ghost and clicking on "content" in the main nav of the admin - there is a 1.5 - 2 second delay before the content actually loads in.

This is a really noticeable lag.

I'd like to do 2 things here:

  1. Research / experiment. Can we actually make this load faster?
  2. Animations

We can reduce the impact of the load delay (poor UX) with some light animations when the content does actually load (nice UX). I have two specific animations in mind:

  • Fade in each post (0.3s each) in the left column, one by one, with a 0.25s delay between each one. This should fade in all of the posts quickly, in order, in a kind of accordion effect from top top bottom.
    • Note: We only need to animate the first 10 posts, as that is the maximum likely to ever to fit on the screen at any one time.
  • Once all posts in the left hand column have loaded, fade in the content preview in the right hand column over 0.5s
@ErisDS
Copy link
Member

ErisDS commented Aug 13, 2013

This would be partly resolved by introducing caching: #173

Also by reducing the number of posts requested at the start (11 I think) and adding infinite scroll #48

@JohnONolan
Copy link
Member Author

FWIW the 2 second delay is occurring with just a single post in the DB

@ErisDS
Copy link
Member

ErisDS commented Aug 13, 2013

Fair point. This probably warrants a bit of investigation to locate the bottleneck, but I'm pretty sure it's the uncached request more than anything else.

@ErisDS
Copy link
Member

ErisDS commented Aug 13, 2013

Should we have loading animations to appear in spaces before content loads?

@JohnONolan
Copy link
Member Author

Was thinking about that - maybe - but let's see if we can actually speed it up first - if not, then we should look at adding a spinner or two.

@ErisDS
Copy link
Member

ErisDS commented Aug 13, 2013

The first ever load without is always going to be slow. I would recommend adding it so that it is there for when it is needed. If things are loaded out of cache, they should be so fast the spinner won't appear.

@ErisDS
Copy link
Member

ErisDS commented Aug 13, 2013

One other thing to note: Amazon EC2 is slow, and expensive. It might not be something we advocate.

@JohnONolan
Copy link
Member Author

This ticket may relate to the email I just forwarded you, subject: "Our AWS bill" heh

@ErisDS
Copy link
Member

ErisDS commented Aug 13, 2013

Drafting a response :)

ErisDS added a commit that referenced this issue Sep 4, 2013
 closes #603, issue #395

- Changed hard-coded 'JOE BLOGGS' to use author data
- We still had api calls loading data server side before rendering pages.. which is unnecessary.
- Only thing using this was editor title, which is now populated client side
- May improve content screen load time.
@ErisDS
Copy link
Member

ErisDS commented Sep 4, 2013

I've pushed a small fix that should improve this a small amount. Other than that I think this is down to two things

I'm going to punt this for review in 0.4 if these 2 issues haven't improved things.

@ErisDS
Copy link
Member

ErisDS commented Sep 16, 2013

@JohnONolan worth checking this again with @jgable's changes

@ErisDS
Copy link
Member

ErisDS commented Oct 23, 2013

Closing this as I think it's no longer a problem

@ErisDS ErisDS closed this as completed Oct 23, 2013
daniellockyer pushed a commit that referenced this issue Jul 20, 2022
refs https://github.com/TryGhost/Team/issues/1580

- When you tried to update a member that doesn't exist, an internal error was thrown
- It should throw a 'not found' error instead
- Optimized when to fetch the initialMember

Tests for 4.x in #14657
Tests for 5.x in #14658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants