-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Sitemaps - what should be included? #4588
Comments
100% yes, totally agree
Yes. Pages are public, they should be public. Setting a post as a page is a hack/workaround for a lack of preview links. So we should have preview links.
Yep. Agree again. The link is standard (See Yoast's SEO plugin for WP), useful, and helpful to the Ghost project by passing an incredibly small amount of link juice to back to the homepage with no impact on any end user. |
+1 everything John said. |
For future proofing, it would probably be a good idea to also exclude tags which have |
I tend to agree. I brought it up mostly as a notice that we should probably stop telling people to do it (at least without a disclaimer).
Fair enough. It's mainly the "generated by" that got me, because (in my case) it wasn't actually generated by the server pointed to by the URL. Like I said, minor and not a big deal at all. |
Agreed on all 3 points. 👍 Just upgraded to 0.5.6 and noticed a lot of unused tags showing up in my sitemap. |
@dannyvankooten you'll be able to remove all those unused tags via tag management now that 0.5.8 is out. As for fixing this up - I think it's pretty clear that these changes are required, but in order to do them we need to add filtering abilities to the API:
Tags do already have a concept of post_count, but there's no way to filter the API based on this property. Authors don't have a concept of post_count. The main question I guess would be how to do filtering based on a post_count property. As a simple version we could use a negation syntax like: Using Another potential syntax is json-style, I think both syntaxes have merit and slightly different purposes. We haven't implemented anything like this in the API yet, but there's likely to be need for both negation and comparison as we move forward. Just throwing this out there to get some thoughts from other people. |
The other area that will need attention is the addition/removal of items into the sitemap indexes that occur in the create/update/delete event hooks in the models. |
I think the password protected posts's tags should be also left out :) [sorry reference removed] |
@letsjustfixit I appreciate you're trying to be helpful, but this comment is confusing. #4993 already states that sitemaps and RSS should not be available on password protected blogs, and we're not intending to provide a feature to password protect individual posts. |
I'm using 0.7, and I've deleted a page .. yet it's still appearing in the sitemap index and Google is reporting it as a 404 .. anyone know how I stop it from appearing in sitemap-pages.xml? |
I'm working on a rewrite of our sitemap system at the moment, which splits the concept of keeping track of what URLs are in the system into a URL service, separate to the generation of the sitemap based on this information. Future sitemaps will only deal with Note to self to ensure we also refactor post.published events on import as part of this. |
Closing this now in favour of #9192, will revisit these ideas when we have a better system in place for tracking URLs. |
Tags
Currently all tags that exist in a blog are being shown in the sitemap. Does it make more sense to only show tags that are assigned to at least one published post? I'm thinking of the case where a tag has been created for a yet-to-be-published post and the author may not want the tag name to be public information.
(Static) Pages
Should all static pages be included by default? I know we've been telling people (unofficially) that static pages can be used as a "secret" share-link-to-preview feature. Now all static pages are part of the public sitemap.
Authors
Like tags, does it make sense to only show authors with at least one published post? Otherwise any and all users that have been created are going to show up in the sitemap.
Last and very minor--I don't think the index page should indicate that the sitemap has been generated by
https://ghost.org/
by default. If we can't get theconfig.url
into the XSL then there probably shouldn't be a link at all.The text was updated successfully, but these errors were encountered: