[5.x] Fixed updating a non-existent member not throwing #14658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBackx
changed the title
Codecov Report
@@ Coverage Diff @@
## main #14658 +/- ##
=======================================
Coverage 60.91% 60.91%
=======================================
Files 569 569
Lines 47221 47221
Branches 4213 4213
=======================================
Hits 28765 28765
Misses 18414 18414
Partials 42 42 Continue to review full report at Codecov.
|
SimonBackx
added a commit
to TryGhost/Members
that referenced
this pull request
May 3, 2022
refs https://github.com/TryGhost/Team/issues/1580 - When you tried to update a member that doesn't exist, an internal error was thrown - It should throw a 'not found' error instead - Optimized when to fetch the initialMember Tests for 4.x in TryGhost/Ghost#14657 Tests for 5.x in TryGhost/Ghost#14658
SimonBackx
force-pushed
the
update-non-existing-member-5-0
branch
from
0b5da7b
to
6df7253
Compare
|
This is blocked until we add the webhook fix in the main branch. |
SimonBackx
force-pushed
the
update-non-existing-member-5-0
branch
from
6df7253
to
44d9d71
Compare
SimonBackx
changed the title
refs https://ghost.slack.com/archives/C02G9E68C/p1651573533380179?thread_ts=1651488536.238499&cid=C02G9E68C - When you try to edit a member that doesn't exist, a 500 error is thrown. - This is fixed by TryGhost/Members#395
refs https://github.com/TryGhost/Team/issues/1580 - Changes in TryGhost/Members#395 - Also adds an extra test without newsletters changes
SimonBackx
force-pushed
the
update-non-existing-member-5-0
branch
from
44d9d71
to
12dc629
Compare
allouis
approved these changes
May 4, 2022
daniellockyer
pushed a commit
that referenced
this pull request
Jul 20, 2022
refs https://github.com/TryGhost/Team/issues/1580 - When you tried to update a member that doesn't exist, an internal error was thrown - It should throw a 'not found' error instead - Optimized when to fetch the initialMember Tests for 4.x in #14657 Tests for 5.x in #14658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/1580
This PR is for the 5.x branch.
4.x: #14657
Blocked by #14664