Ensured replies remain visible when parent comment is being edited #21756
+252
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REF https://linear.app/ghost/issue/PLG-274/prevent-replies-from-being-hidden-when-editing-parent-comment - Currently, replies are hidden when the parent comment is being edited. This PR ensures that replies remain visible when the parent comment is being edited. - To achieve this, the `CommentComponent` now checks if the parent comment is being edited. If so, the comment content is swapped by the EditForm, while the comment's avatar, header, menu, and replies remain visible. - The Form component now only renders the FormEditor. A FormWrapper component is used to wrap the avatar and comment header. - This Form component is used in the EditForm without the FormWrapper, as it is already wrapped in the CommentComponent. - The ReplyForm and the MainForm use the FormWrapper. - The Avatar component now also accepts a `member` prop, which is used to display the avatar image. This is because it's no longer used inside the Form component.
Comment on lines
+196
to
+204
| mockedApi.addComment({ | ||
| member: { | ||
| id: 'test-id', | ||
| uuid: 'test-uuid', | ||
| name: 'Test User', | ||
| avatar: '', | ||
| expertise: '' | ||
| } | ||
| }); |
There was a problem hiding this comment.
This test was failing, and I didn't understand why – I hadn't touched the avatarSaturation, the only thing that changed is that the Avatar component isn't passed in the Form anymore but in FormWrapper. Cursor suggested this because in FormWrapper, I'm passing member directly as a prop to Avatar, while the test is expecting to find an Avatar that's rendered for a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF https://linear.app/ghost/issue/PLG-274/prevent-replies-from-being-hidden-when-editing-parent-comment
CommentComponentnow checks if the parent comment is being edited. If so, the comment content is swapped by the EditForm, while the comment's avatar, header, menu, and replies remain visible.memberprop, which is used to display the avatar image. This is because it's no longer used inside the Form component.