Pipeline-ify configuration/themes/upload APIs #5515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API options are now merged, so this will need a bit of an update 😉 |
|
@ErisDS Updated |
| return canThis(options.context).browse.theme().then(function () { | ||
| function handlePermissions(options) { | ||
| return canThis(options.context).browse.theme().then(function () { | ||
| return Promise.resolve(); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
The build failure on this is genuine 😉 |
|
@halfdan Can you get this one fixed up plz? |
|
Any chance of a fixup here or should I close? |
|
Gonna close for now so that other people can pick up these pieces. |
Closed
hoxoa
added a commit
to hoxoa/Ghost
that referenced
this pull request
Oct 27, 2015
refs TryGhost#5515 - fix code style errors - change return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5508