Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split RSS module into controller + other #9224

Merged
merged 9 commits into from
Nov 7, 2017

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Nov 7, 2017

refs #5091, refs #9192

  • This is similar to Split renderChannel into controller + renderer #9218, in that I'm revealing bits of code that are "controllers" in our codebase. As opposed to routes, services, renderers etc.
  • This also reveals some code which is identical to the channels controller
  • There is more to do here, but for now I've got the module split up, and the tests split and improved.
  • Next I'll split RSS into controller + service, DRY up the controller code, etc

@ErisDS ErisDS merged commit 60fd986 into TryGhost:master Nov 7, 2017
@ErisDS ErisDS deleted the rss-controller-split branch November 7, 2017 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant