-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/use self hosted runner #1931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
kowalski
reviewed
Oct 6, 2023
kowalski
approved these changes
Oct 9, 2023
siepra
added a commit
that referenced
this pull request
Oct 9, 2023
* Add e2e iOS workflow * Dummy mobile change * Navigate to project's directory * Intentionally break the test * Use checkout and setup project * Use project directory * Don't reuse setup environment step * Correct step * Print location * Skip path * Install dependencies * Add more steps * Point to mobile dir * Dummy change * Git lfs * Fix test * Add Detox CI config * Decrease timeout * Use more labels for runner
holmesworcester
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will someone external to our team be able to trigger this workflow without approval? That would be a security risk, because they could run code and affect future runs.
siepra
added a commit
that referenced
this pull request
Oct 9, 2023
* Mark packages private * Add suffix to desktop package name * Update desktop package-lock * Don't trigger desktop e2e tests on mobile changes * Unify workflows naming * Enhance PR checklist with mobile specific checks * Extract Desktop RTL tests * Change scope name in build actions * Remove extra branches from lerna config * Update setEnvs script * Unblock mobile e2e tests * Allow versioning from current branch * Publish - backend-bundle@2.0.0-alpha.18 - @quiet/backend@2.0.0-alpha.18 - @quiet/common@2.0.0-alpha.18 - @quiet/desktop@2.0.0-alpha.18 - e2e-tests@2.0.0-alpha.18 - @quiet/eslint-config@2.0.0-alpha.18 - @quiet/identity@2.0.0-alpha.18 - integration-tests@2.0.0-alpha.18 - @quiet/logger@2.0.0-alpha.18 - @quiet/mobile@2.0.0-alpha.18 - @quiet/state-manager@2.0.0-alpha.18 - @quiet/types@2.0.0-alpha.18 * Fix socket events queue * Use better runner for Android build * Publish - @quiet/backend@2.0.0-alpha.19 - @quiet/mobile@2.0.0-alpha.19 * Prevent running desktop e2e tests on wrong tag * Add debug logs for deep link issue * Publish - @quiet/mobile@2.0.0-alpha.20 * Revert "Prevent running desktop e2e tests on wrong tag" This reverts commit 49e87a2. * Prevent running desktop e2e tests on wrong tag * Ci/use self hosted runner (#1931) * Add e2e iOS workflow * Dummy mobile change * Navigate to project's directory * Intentionally break the test * Use checkout and setup project * Use project directory * Don't reuse setup environment step * Correct step * Print location * Skip path * Install dependencies * Add more steps * Point to mobile dir * Dummy change * Git lfs * Fix test * Add Detox CI config * Decrease timeout * Use more labels for runner * Fix/deeplinking (#1935) * Debug logs * Wait for redux before storing invitation code * Remove debug logs * Workaround for ARM64 GCC preprocessors * Make Detox tests work (Apple Silicon) (#1929) Co-authored-by: github@zbay.llc <github@zbay.llc> * Fix lint --------- Co-authored-by: github@zbay.llc <github@zbay.llc> * Publish - @quiet/backend@2.0.0-alpha.20 - @quiet/mobile@2.0.0-alpha.21 * Change project name occurencies in README --------- Co-authored-by: Vin Kabuki <vincent.kabacky@gmail.com> Co-authored-by: github@zbay.llc <github@zbay.llc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: