fix: Adds a quick fix for the iOS sync issue after suspend #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS appears to not be syncing correctly after resuming from suspend. It looks like this is due to the libp2p auto-dialler getting stuck connecting to the Tor HTTP tunnel port which is replaced after suspend/resume. This commit enables the WebsocketOverTor transport to use the `dialTimeout` correctly. But still this means the current dialer waits for `dialTimeout` to try another peer, and we currently have `dialTimeout` set to 2 minutes. Ideally, we can find a better approach for closing any sockets when suspending the app or detecting when we are trying to connect to a port that nothing is listening on, if that's possible.
leblowl
pushed a commit
that referenced
this pull request
Apr 10, 2024
iOS appears to not be syncing correctly after resuming from suspend. It looks like this is due to the libp2p auto-dialler getting stuck connecting to the Tor HTTP tunnel port which is replaced after suspend/resume. This commit enables the WebsocketOverTor transport to use the `dialTimeout` correctly. But still this means the current dialer waits for `dialTimeout` to try another peer, and we currently have `dialTimeout` set to 2 minutes. Ideally, we can find a better approach for closing any sockets when suspending the app or detecting when we are trying to connect to a port that nothing is listening on, if that's possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS appears to not be syncing correctly after resuming from suspend. It looks like this is due to the libp2p auto-dialer getting stuck connecting to the Tor HTTP tunnel port which is replaced after suspend/resume. This commit enables the WebsocketOverTor transport to use the
dialTimeoutcorrectly. But still this means the current dialer waits fordialTimeoutto try another peer, and we currently havedialTimeoutset to 2 minutes. Ideally, we can find a better approach for closing any sockets when suspending the app or detecting when we are trying to connect to a port that nothing is listening on, if that's possible. Using thedialTimeoutcorrectly, is still important regardless.This is sort of a solution for #2396
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: