Fix bbox-clip point intersection handling #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure a polygon that has a single point touching the bounding box will be handled without an error.
|
Thanks Tim for sending over a "bug" & a solution (PR) at the same time 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where only a single point touches the bounding box, it's possible for
lineclipto return a line with multiple identical coordinates. For some cases it emits 4 coordinates, which is a zero-area polygon, and everything works fine. For the provided test case, it emits 3 coordinates.This patch just sanity-checks the
lineclipoutput so it only attempts to output polygons with at least 4 coordinates.