Skip to content

Conversation

@penelopeysm
Copy link
Member

closes #1166

not yet done, still need to sit down and write the show method

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Benchmark Report

  • this PR's head: 554aba899560e58d845dbb2cf82dbe9c999fbbe5
  • base branch: ffc4623cc46b7058b793c2bcc3fa092e14eb7803

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬─────────────────────────────────┬────────────────────────────┬─────────────────────────────────┐
│                       │       │             │                   │        │        t(eval) / t(ref)         │     t(grad) / t(eval)      │        t(grad) / t(ref)         │
│                       │       │             │                   │        │ ──────────┬───────────┬──────── │ ───────┬─────────┬──────── │ ──────────┬───────────┬──────── │
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │      base │   this PR │ speedup │   base │ this PR │ speedup │      base │   this PR │ speedup │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│               Dynamic │    10 │    mooncake │             typed │   true │    369.47 │    360.94 │    1.02 │   9.90 │   11.50 │    0.86 │   3659.41 │   4149.07 │    0.88 │
│                   LDA │    12 │ reversediff │             typed │   true │   2592.18 │   2611.81 │    0.99 │   5.20 │    5.08 │    1.02 │  13486.26 │  13269.62 │    1.02 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │ 106057.67 │ 106431.10 │    1.00 │   4.15 │    4.15 │    1.00 │ 440543.49 │ 442164.72 │    1.00 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │   8914.82 │   8207.82 │    1.09 │   4.64 │    4.56 │    1.02 │  41338.97 │  37439.55 │    1.10 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │  32912.76 │  32513.94 │    1.01 │  10.08 │   10.22 │    0.99 │ 331600.86 │ 332453.15 │    1.00 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │   3613.50 │   3568.13 │    1.01 │   9.33 │    9.37 │    1.00 │  33729.01 │  33448.82 │    1.01 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │      2.72 │      2.69 │    1.01 │   3.97 │    4.06 │    0.98 │     10.82 │     10.92 │    0.99 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │   1214.51 │   1220.30 │    1.00 │ 123.03 │   61.01 │    2.02 │ 149426.95 │  74454.21 │    2.01 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │       err │       err │     err │    err │     err │     err │       err │       err │     err │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │       err │       err │     err │    err │     err │     err │       err │       err │     err │
│           Smorgasbord │   201 │      enzyme │             typed │   true │   1725.20 │   1663.25 │    1.04 │   5.71 │    5.69 │    1.00 │   9844.23 │   9457.41 │    1.04 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │   1709.31 │   1685.40 │    1.01 │   5.31 │    5.26 │    1.01 │   9077.93 │   8862.23 │    1.02 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ reversediff │             typed │   true │   1704.57 │   1669.58 │    1.02 │  87.98 │   92.90 │    0.95 │ 149966.69 │ 155098.88 │    0.97 │
│           Smorgasbord │   201 │ forwarddiff │      typed_vector │   true │   1687.90 │   1661.67 │    1.02 │  55.94 │   56.62 │    0.99 │  94417.75 │  94084.58 │    1.00 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │   1688.77 │   1665.62 │    1.01 │  56.70 │  120.90 │    0.47 │  95757.54 │ 201367.91 │    0.48 │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼───────────┼───────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ forwarddiff │    untyped_vector │   true │   1682.01 │   1660.88 │    1.01 │  56.91 │   54.87 │    1.04 │  95725.45 │  91132.03 │    1.05 │
│              Submodel │     1 │    mooncake │             typed │   true │      7.18 │      7.18 │    1.00 │   5.20 │    5.20 │    1.00 │     37.36 │     37.29 │    1.00 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴───────────┴───────────┴─────────┴────────┴─────────┴─────────┴───────────┴───────────┴─────────┘

@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.96%. Comparing base (ffc4623) to head (554aba8).

Files with missing lines Patch % Lines
src/test_utils/ad.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   80.01%   79.96%   -0.05%     
==========================================
  Files          41       41              
  Lines        3877     3879       +2     
==========================================
  Hits         3102     3102              
- Misses        775      777       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run_ad could print some stuff better

2 participants