-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerting): Add group-specific WebHook URL for Discord #271
Conversation
Add group-specific webhook URL for discord alert Provides support for paging multiple Discords based on the group selector while keeping backward compatibility to the old Discords configuration manifest integration per team can be specified in the overrides sections in an array form. ref: TwiN#96 Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@TwiN All Done, Please help to review again. |
Co-authored-by: TwiN <twin@linux.com>
Co-authored-by: TwiN <twin@linux.com>
@TwiN All Done. |
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 83.70% 83.68% -0.03%
==========================================
Files 53 53
Lines 3462 3476 +14
==========================================
+ Hits 2898 2909 +11
- Misses 439 441 +2
- Partials 125 126 +1
Continue to review full report at Codecov.
|
Co-authored-by: TwiN <twin@linux.com>
@TwiN Done. Please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I missed the notification.
Thank you for the contribution!
Add group-specific webhook URL for discord alert
Provides support for paging multiple Discords based on the group selector while keeping backward compatibility to the old Discords configuration manifest
integration per team can be specified in the overrides sections in an array form.
ref: #96
Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com