Fix vue related tests #122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'd already merged my own PR before I noticed the one you'd submitted. I think it's good to have the test pack reflecting the usage of vue-loader 15 - and so I've closed your PR in favour of this one. My apologies for your wasted effort there; I hope that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ts-loader4.3.1 a fix (TypeStrong/ts-loader#782) exposes a usage problem that was previously present in the integration tests. This PR uses the correct options setup to fix the tests. Note thets-loaderchange does not affectvue-loader15. (See comments in that PR for more context)Also apologies for the noise in the PR regarding removed whitespaces.