Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Adding line offset for code problems #976

Merged
merged 12 commits into from
Dec 15, 2023

Commits on Dec 8, 2023

  1. [frontend/task_problems] Adding line offset for CodeMirror code blocks

    A teacher could need to change the code lines offset in order to send back correct review when parsing student code into a template.
    
    Problem : changing the first_line parameter in the template_helper.render() function is effective only after restarting the server.
    AlexandreDoneux committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    636b03d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17c56c2 View commit details
    Browse the repository at this point in the history
  3. [frontend/common] Fixing firstLineNumber param for CodeMirror

    Was checking the value of data-x-first-line only for textareas with code-editor class. Now doing it in registerCodeEditor() function for every case.
    AlexandreDoneux committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    d1542aa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    57d6af4 View commit details
    Browse the repository at this point in the history
  5. Retrieving line offset from subproblem form, checking it's value at s…

    …ubmit and apply it to the problem's code block
    AlexandreDoneux committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f695842 View commit details
    Browse the repository at this point in the history
  6. [static/common] fixing first line transformation to int for CodeMirror

    Was changing the firstline value into a integer or set it to 1 if it was not given. Was oing it outside the registerCodeEditor() function. But as it is used in other places this action wasn't performed each time. Doing this transformation inside the function now.
    AlexandreDoneux committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    26fcaf9 View commit details
    Browse the repository at this point in the history
  7. [pages/task_edit] Allowing the line offset field to be empty

    When the line offset was empty it was retrieved as an empty string. It couldn't be transformed into an integer so an error message appeared. Fixed that.
    AlexandreDoneux committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f36d819 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    59596f8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    692ab98 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8ed921d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b35cb77 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. [common/tasks_problems] not storing offset when no offset given

    Instead of setting it to 1 (default value) we do not store it
    
    Co-authored-by: Anthony Gégo <anthony.gego@uclouvain.be>
    AlexandreDoneux and anthonygego authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    207af6f View commit details
    Browse the repository at this point in the history