-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Adding line offset for code problems #976
Commits on Dec 8, 2023
-
[frontend/task_problems] Adding line offset for CodeMirror code blocks
A teacher could need to change the code lines offset in order to send back correct review when parsing student code into a template. Problem : changing the first_line parameter in the template_helper.render() function is effective only after restarting the server.
Configuration menu - View commit details
-
Copy full SHA for 636b03d - Browse repository at this point
Copy the full SHA 636b03dView commit details -
[frontend/task_problems] Displaying no line offset when first_line pa…
…rameter not defined
Configuration menu - View commit details
-
Copy full SHA for 17c56c2 - Browse repository at this point
Copy the full SHA 17c56c2View commit details -
[frontend/common] Fixing firstLineNumber param for CodeMirror
Was checking the value of data-x-first-line only for textareas with code-editor class. Now doing it in registerCodeEditor() function for every case.
Configuration menu - View commit details
-
Copy full SHA for d1542aa - Browse repository at this point
Copy the full SHA d1542aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57d6af4 - Browse repository at this point
Copy the full SHA 57d6af4View commit details -
Retrieving line offset from subproblem form, checking it's value at s…
…ubmit and apply it to the problem's code block
Configuration menu - View commit details
-
Copy full SHA for f695842 - Browse repository at this point
Copy the full SHA f695842View commit details -
[static/common] fixing first line transformation to int for CodeMirror
Was changing the firstline value into a integer or set it to 1 if it was not given. Was oing it outside the registerCodeEditor() function. But as it is used in other places this action wasn't performed each time. Doing this transformation inside the function now.
Configuration menu - View commit details
-
Copy full SHA for 26fcaf9 - Browse repository at this point
Copy the full SHA 26fcaf9View commit details -
[pages/task_edit] Allowing the line offset field to be empty
When the line offset was empty it was retrieved as an empty string. It couldn't be transformed into an integer so an error message appeared. Fixed that.
Configuration menu - View commit details
-
Copy full SHA for f36d819 - Browse repository at this point
Copy the full SHA f36d819View commit details -
[Fronted/task_edit] Raising error in CodeProblem.parse_problem() inst…
…ead of task_edit.py
Configuration menu - View commit details
-
Copy full SHA for 59596f8 - Browse repository at this point
Copy the full SHA 59596f8View commit details -
[static/common] Replacing parameter check in registerCodeEditor() wit…
…h default parameter
Configuration menu - View commit details
-
Copy full SHA for 692ab98 - Browse repository at this point
Copy the full SHA 692ab98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed921d - Browse repository at this point
Copy the full SHA 8ed921dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b35cb77 - Browse repository at this point
Copy the full SHA b35cb77View commit details
Commits on Dec 14, 2023
-
[common/tasks_problems] not storing offset when no offset given
Instead of setting it to 1 (default value) we do not store it Co-authored-by: Anthony Gégo <anthony.gego@uclouvain.be>
Configuration menu - View commit details
-
Copy full SHA for 207af6f - Browse repository at this point
Copy the full SHA 207af6fView commit details