From 2d9aa5f12ede6caff4de2c0a0f5dfea5c9dc2e50 Mon Sep 17 00:00:00 2001 From: Nayden Naydenov Date: Thu, 3 Jun 2021 11:05:23 +0300 Subject: [PATCH 1/2] feat(ui5-li): title attribute handle --- packages/main/src/ListItem.hbs | 1 + packages/main/src/ListItem.js | 11 +++++++++++ packages/main/src/Tree.hbs | 1 + packages/main/src/TreeItem.js | 11 +++++++++++ 4 files changed, 24 insertions(+) diff --git a/packages/main/src/ListItem.hbs b/packages/main/src/ListItem.hbs index 2497132100e5..bb46579a5f3e 100644 --- a/packages/main/src/ListItem.hbs +++ b/packages/main/src/ListItem.hbs @@ -13,6 +13,7 @@ @click="{{_onclick}}" aria-selected="{{ariaSelected}}" role="{{_accInfo.role}}" + title="{{title}}" aria-expanded="{{_accInfo.ariaExpanded}}" aria-level="{{_accInfo.ariaLevel}}" aria-posinset="{{_accInfo.posinset}}" diff --git a/packages/main/src/ListItem.js b/packages/main/src/ListItem.js index fbd3611635ca..6a267c68ea4d 100644 --- a/packages/main/src/ListItem.js +++ b/packages/main/src/ListItem.js @@ -46,6 +46,17 @@ const metadata = { type: Boolean, }, + /** + * Defines the tooltip of the component. + * @type {string} + * @defaultvalue "" + * @private + * @since 1.0.0-rc.15 + */ + title: { + type: String, + }, + /** * Indicates if the list item is actionable, e.g has hover and pressed effects. * diff --git a/packages/main/src/Tree.hbs b/packages/main/src/Tree.hbs index 3fbfcf5fb836..cd7c3a07d7b4 100644 --- a/packages/main/src/Tree.hbs +++ b/packages/main/src/Tree.hbs @@ -17,6 +17,7 @@ icon="{{this.treeItem.icon}}" additional-text="{{this.treeItem.additionalText}}" additional-text-state="{{this.treeItem.additionalTextState}}" + title="{{this.treeItem.title}}" ?_toggle-button-end="{{ ../_toggleButtonEnd}}" ?_minimal="{{../_minimal}}" .treeItem="{{this.treeItem}}" diff --git a/packages/main/src/TreeItem.js b/packages/main/src/TreeItem.js index 67a0813824fd..2bc24d8c67f1 100644 --- a/packages/main/src/TreeItem.js +++ b/packages/main/src/TreeItem.js @@ -91,6 +91,17 @@ const metadata = { type: ValueState, defaultValue: ValueState.None, }, + + /** + * Defines the tooltip of the component. + * @type {string} + * @defaultvalue "" + * @private + * @since 1.0.0-rc.15 + */ + title: { + type: String, + }, }, managedSlots: true, slots: /** @lends sap.ui.webcomponents.main.TreeItem.prototype */ { From be40056407aa60236e2b17089d1eaccfe2c59936 Mon Sep 17 00:00:00 2001 From: Nayden Naydenov Date: Thu, 3 Jun 2021 14:24:39 +0300 Subject: [PATCH 2/2] lint --- packages/main/src/ListItem.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/ListItem.js b/packages/main/src/ListItem.js index 6a267c68ea4d..03b5cdf9e02b 100644 --- a/packages/main/src/ListItem.js +++ b/packages/main/src/ListItem.js @@ -53,7 +53,7 @@ const metadata = { * @private * @since 1.0.0-rc.15 */ - title: { + title: { type: String, },