CSL-18-guarantor-details #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertMcCann
requested review from
dk4g,
vinodhasamiyappanHO and
jamiecarterHO
dk4g
requested changes
Nov 22, 2024
| "notUrl": "Your answer must not contain URLs or links" | ||
| }, | ||
| "guarantor-email-address": { | ||
| "required": "Enter an email address" |
There was a problem hiding this comment.
missing
"email": "Enter a real email address"
| className: ['govuk-input', 'govuk-!-width-two-thirds'] | ||
| }, | ||
| 'guarantor-email-address': { | ||
| validate: ['required'], |
There was a problem hiding this comment.
worth adding 'email' validator
dk4g
approved these changes
Nov 22, 2024
vinodhasamiyappanHO
approved these changes
Nov 22, 2024
2 tasks
dk4g
added a commit
that referenced
this pull request
Nov 27, 2024
* CSL-20-premises-address-contact-details (#3) * CSL 13 - PCA - Added Licence holder details and address page (#7) * CSL-21: PCA - Responsible officer details (#6) * CSL-18: Guarantor details (#13) * CSL 28- PCA - Added new pages received criminal convictions, Invoicing address and contact details (#14) --------- Co-authored-by: Vinodha Samiyappan <155738658+vinodhasamiyappanHO@users.noreply.github.com> Co-authored-by: dk4g <157156245+dk4g@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates CSL-18
What?
Add guarantor details pages to Precursor Chemicals journey
Why?
How?
Testing?
Screenshots (optional)
Anything Else? (optional)
Check list