-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSL-4: Feature - PCA Finalise Application #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add premises address page; add premises contact details page
* Added Licence details and address page in precursor chemicals new application flow * Added field level validation for company number and removed from behaviour
* CSL-21: Responsible officer details (About the applicants) * Bugfix: CSL-52 - Optional field throws error with and without data in the field
…g address and contact details (#14) * Added criminal convictions, invoicing address and contact details pages to the new application flow
…finalise-application
…ls in PCA new application flow (#18)
…finalise-application
* add regulatory affairs pages for Precursor Chemicals
dk4g
reviewed
Dec 3, 2024
dk4g
reviewed
Dec 3, 2024
dk4g
approved these changes
Dec 3, 2024
RobertMcCann
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A feature branch containing tickets relating to the 'Finalise Application' section for Precursor Chemicals
Covers tickets:
CSL-27 - 1.12 PCA - Which email address should the licence be sent to (Finalise application)
CSL-15 - 1.13 Will the regulatory affairs and compliance officer discharge all licence responsibilities
Why?
How?
Testing?
Screenshots (optional)
Anything Else? (optional)
Check list