Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSL-4: Feature - PCA Finalise Application #17

Merged
merged 26 commits into from
Dec 3, 2024

Conversation

vinodhasamiyappanHO
Copy link
Contributor

What?

A feature branch containing tickets relating to the 'Finalise Application' section for Precursor Chemicals

Covers tickets:
CSL-27 - 1.12 PCA - Which email address should the licence be sent to (Finalise application)
CSL-15 - 1.13 Will the regulatory affairs and compliance officer discharge all licence responsibilities

Why?

How?

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request
  • I have written tests (if relevant)

RobertMcCann and others added 19 commits November 18, 2024 12:18
* add premises address page; add premises contact details page
* Added Licence details and address page in precursor chemicals new application flow

* Added field level validation for company number and removed from behaviour
* CSL-21: Responsible officer details (About the applicants)
* Bugfix: CSL-52 - Optional field throws error with and without data in the field
…g address and contact details (#14)

* Added criminal convictions, invoicing address and contact details pages to the new application flow
Base automatically changed from feature/CSL-4-about-the-applicants to main November 27, 2024 13:43
@dk4g dk4g requested a review from RobertMcCann December 3, 2024 10:40
@dk4g dk4g requested review from jamiecarterHO and dk4g December 3, 2024 10:40
@vinodhasamiyappanHO vinodhasamiyappanHO marked this pull request as ready for review December 3, 2024 10:41
Copy link
Contributor

@RobertMcCann RobertMcCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vinodhasamiyappanHO vinodhasamiyappanHO merged commit 2a23e98 into main Dec 3, 2024
3 checks passed
@vinodhasamiyappanHO vinodhasamiyappanHO deleted the feature/CSL-4-finalise-application branch December 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants