Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): group renovate storybook updates and fix validation errors #1159

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

minhlai
Copy link
Contributor

@minhlai minhlai commented Nov 20, 2023

Proposed changes

  • Add @storybook PackageRule for grouping Storybook updates
  • Update description config option in PackageRules to be arrays of strings instead of strings
  • Update manager config option to be matchManagers

Changes fix these validation errors that must have appeared when Renovate had updates that we didn't keep up with:

DEBUG: Validation Errors
{
  "errors": "Configuration option `packageRules[1].description` should be a list (Array), Configuration option `packageRules[2].description` should be a list (Array), Configuration option `packageRules[3].description` should be a list (Array), Configuration option `packageRules[4].description` should be a list (Array), Configuration option `packageRules[7].description` should be a list (Array), Configuration option `packageRules[8].description` should be a list (Array), Invalid configuration option: packageRules[1].managers, Invalid configuration option: packageRules[2].managers, Invalid configuration option: packageRules[3].managers, Invalid configuration option: packageRules[4].managers, Invalid configuration option: packageRules[6].managers"
}

Reviewer notes

Setup

Start the system

yarn services:up
yarn dev
cd ../ussf-portal-cms
yarn dev

Login to the portal http://localhost:3000

Start storybook

yarn storybook

Login to storybook http://localhost:6006, though the command above should open it for you


Code review steps

As the original developer, I have

  • Met the acceptance criteria
  • Created new stories in Storybook if applicable
  • Created/modified automated unit tests in Jest
  • Created/modified automated E2E tests
  • Followed guidelines for zero-downtime deploys, if applicable
  • Use ANDI to check for basic a11y issues

As a reviewer, I have

Check out our How to review a pull request document.


Screenshots

@minhlai minhlai marked this pull request as ready for review November 20, 2023 22:13
@minhlai minhlai requested a review from a team as a code owner November 20, 2023 22:13
@minhlai minhlai changed the title chore(deps): group renovate storybook updates chore(deps): group renovate storybook updates and fix validation errors Nov 20, 2023
Copy link
Contributor

@gidjin gidjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding storybook!

@mergify mergify bot merged commit 700c7fb into main Nov 21, 2023
16 checks passed
@mergify mergify bot deleted the renovate/reconfigure branch November 21, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants