Feature/hide data icon button #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Overall looks good, and seems very useful! From a design perspective, is the visibility toggle discoverable? |
|
I just tabbed through and it could access the toggles |
|
The biggest thing I noticed is that it seems to only appear when you hover over the color of a selected course, and there's no indication that the toggle is present there. |
|
Good point. I remember thinking it looked weird to always have the Visibility icon there but its better to be clear. New commit should fix that |
dlaunikitis
added a commit
that referenced
this pull request
Oct 25, 2023
* Revert horizontal bar graph direction change (#78) Revert horizontal bar graph direction change, change GPA graphs to be vertical graphs * Link preview typo fix (#75) * Add y-axis formatting (#77) Add y-axis formatting, using percents on main grades graph and GPAs with 2 decimal points on others * Add autocomplete default first option selection and option hover effect (#76) * Maintain consistent usage of React MUI components (#79) * Update CardContents.tsx * Update ProfessorCard.tsx * Bug/flashing autocomplete update (#81) * Shorter AbortController solution * Simpler AbortController Fix * Feature/aggregation total count display (#80) * Student aggregation total count display * Add commas * Remove print statement --------- Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * MUI Icons (#91) * MUI Icons * Remove SearchIcon * Update language (#93) Percentage taking again sounds like percentage of students that failed and had to retake. Department of <> at University of Texas at Dallas on all professors is redundant. * Bug fix: Horizontal bar label formatter (#92) * Move axis label formatter for horizontal bar graph * Fix type error * Comment out print statements (#87) clarify language Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * Feature/autocomplete section suggestions (#82) * Add new query format * Implement radix tree to lower file size from 70MB to 24MB Return max of 20 options * Autocomplete refinements * Remove all sections but HON possibility to add HNx and 0Lx sections * [Internal] Check for formatting in CI (#85) * Create main.yml * Add npm install * Shorter npm install and prettier fix * Run prettier --write Update .prettierignore * .prettierignore formatting --------- Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * Add share button (#90) * Add share button * Fixes Copy correct URL URL copy confirmation White share icon * Remove skip share menu to test copy * Add Vercel Analytics (#89) * add vercel analytics * update package-lock.json * Revert autofocus (#95) * Professor card updates (#86) * Cache professor data API calls * Remove professor cards not found * Show box for professor RMP not found * Add cache expiry * Dashboard organization * Remove duplicate professor cards * Remove console.log * Change RMP cache to 1 month * Pad professor not found * Revert ProfessorCard.tsx * Run prettier on failing file --------- Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * Fix highlighting * Search bolding * Remove print * Support number before prefix * process.env test * Build fix * Console log * Fix when to show icon * Revert package.json change * Use correct env name * Vercel test * Fix env var * Styling * Build fix * Finalization * Add tooltip * Update CardContents.tsx (#96) Changed 5-difficulty to 6-difficulty, since difficulty is a scale from 1 to 5 * Common Types and Functions (#103) * Common SearchQuery, SearchQueryLabel, and SearchQueryEqual * Common colors * Package and file cleanup (#106) * File cleanup * chore: Remove/implement packages Moves some packages from dependencies to devDependencies Actually use all eslint, babel, and commitlint packages * Build fixes * Update packages * Fix warnings (most) * Fix autocomplete build errors, move to ts-node * Node version 18 * Prettier * Fix copy link not working * Prettier * Prefetch dashboard (#109) * Prefetch * useEffect * Update index.tsx Should resolve build failure * Ran lint fix --------- Co-authored-by: Jake <Jake3231@users.noreply.github.com> * Open GitHub commit for this instance * Feature/what you can enter popup (#108) * Add what you can enter box * Prettier * Removed unused import Popper --------- Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * Dark mode (#101) * First attempt at dark mode TODO: fix expandableSearchBar color, not the same as searchBar's for some reason fix dashboard background color, always white amplify shadows, hardder to see on dark * Color fixes * Prettier * Fix graph color * Build fixes * Build fixes * Remove box+whisker+stdev (#100) * Remove box and whisker and standard deviation bar graphs * Prettier * Average calc fix * Remove average graph, move to expandableSearchGrid * Revert subtitle addition * Prettier * Add question mark tooltip disclaimer * Prettier * Revert autocomplete_graph.json * Don't show question mark on loading --------- Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * Feature/related classes list (#102) * Print related queries to console * Tweak suggestions * Remove duplicates * Prettier * Prioritize professor suggestions * Custom limit * Basic UI * UI refinements * Adding functionality * Build fixes * Prettier * Prep for dark mode * Common SearchQuery, SearchQueryLabel, and SearchQueryEqual * Print related queries to console * Tweak suggestions * Remove duplicates * Prettier * Prioritize professor suggestions * Custom limit * Basic UI * UI refinements * Adding functionality * Build fixes * Prettier * Prep for dark mode * Integrate Common Types and Functions * Integrate Common Types and Functions * Layout fixes * Layout fix * Feature/full screen graphs (#104) * Full Screen Button Added full screen button to only VerticalBarGraph for testing * Full Screen Button Added full screen button to only VerticalBarGraph for testing * Implement using MUI modal * Reduce ApexCharts toolbar z index so it doesn't display over autocomplete suggestions * Disable animation on open full screen * Updated GitHub settings & issue templates (#115) * Update bug_report_issue_template.yml Removed Willie from being assigned * Update config.yml Updated links & verbage * Update feature_request_issue_template.md Removed Willie as the assignee * Update ratemyprofessorScraper.ts (#111) * Update ratemyprofessorScraper.ts Fix the format of the scraper * Update ratemyprofessorScraper.ts * Run prettier --------- Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * Move academic session select (#110) * Remove box and whisker and standard deviation bar graphs * Prettier * Average calc fix * Remove average graph, move to expandableSearchGrid * Revert subtitle addition * Prettier * Add question mark tooltip disclaimer * Prettier * Revert autocomplete_graph.json * Don't show question mark on loading * Move time range picker * Lint fix * Feature/hide data icon button (#105) * Implementation * Remove hover transition until load * Always show icon * Build fix * Feature/rmp link (#88) * Update CardContents.tsx * Update CardContents.tsx * Update CardContents.tsx * Update CardContents.tsx * Update CardContents.tsx * Update CardContents.tsx * Update CardContents.tsx * Update CardContents.tsx * Move and restyle link * fix/put the link style in the wrong place * RMP link format change * Revert "RMP link format change" This reverts commit b38d324. * Redelete CardContents.tsx * Revert autocomplete_graph.json --------- Co-authored-by: Tyler Hill <gotyhill@gmail.com> * Blank search updates (#98) * Update search placeholder * Remove splash page suggestions on empty search * Dashboard search blank suggestions based on last search query Remove custom option rendering for proper highlighting, retains primary color Switch autocompletes multiple to false * Remove box and whisker and standard deviation bar graphs * Revert "Remove box and whisker and standard deviation bar graphs" This reverts commit 75fd661. * Retain renderOption * Common SearchQuery, SearchQueryLabel, and SearchQueryEqual * Update search placeholder * Remove splash page suggestions on empty search * Dashboard search blank suggestions based on last search query Remove custom option rendering for proper highlighting, retains primary color Switch autocompletes multiple to false * Remove box and whisker and standard deviation bar graphs * Revert "Remove box and whisker and standard deviation bar graphs" This reverts commit 75fd661. * Build fixes * Build fix * Fix merge of branch 'develop' into blank-search-updates * Fix searchBar using data.output instead of data.data * Make limit optional in autocomplete call * Removed comment, oops --------- Co-authored-by: William Skaggs <wskaggs3262@gmail.com> * Number prefix query order (#97) * Allow number prefix query order Ex. "1200 CS" as users tended to do this Autocomplete bug fixes along the way also included * Prettier fix * Graph ordering fix * Recompile generateAutocompleteGraph * Prioritize shorter answers so that prefixes show first * Fix some data not included in graph, CE not being included because of last name Cease * Optional prefix in <number><prefix> * 1200CS highlighting fix * Remove comments * Remove comments 2 * Redelete `scripts/generateAutocompleteGraph.js` * Comment added * Add comments to autocomplete.ts * Undefined check in bfs * Add NoDAG options to npm run dev and npm run build --------- Co-authored-by: Tyler Hill <gotyhill@gmail.com> Co-authored-by: George-Zhang5246 <70183314+George-Zhang5246@users.noreply.github.com> Co-authored-by: Caleb Lim <47403443+ZzRanger@users.noreply.github.com> Co-authored-by: Jake <Jake3231@users.noreply.github.com> Co-authored-by: David Launikitis <55267400+dlaunikitis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow hiding queries from all graphs and professor tab
What Changed
Added a button in each
searchTermCardto toggle visibility. This generates a visibility array in theexpandableSearchGridwhich is then passed to the dashboard. The dashboard does not rerun data fetching and instead excludes datasets at the last time possible, before becoming props for the graphs/prof cards.