Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Felix Yang Onboarding #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Felix Yang Onboarding #11

wants to merge 3 commits into from

Conversation

FxJYg
Copy link

@FxJYg FxJYg commented Feb 1, 2025

Purpose

Completed the GS on-boarding task for backend (I am not too confident with the middleware logging). Will do frontend later.

New Changes

  • Data validation for commands for data_models.
  • Implemented POST and DELETE endpoints for Command.
  • Logger Middleware to log information.

Testing

  • Tested the POST and DELETE endpoints as well as logging information.
  • Passed Pytest

Outstanding Changes

@FxJYg FxJYg changed the title Passed all tests Felix Yang Onboarding Feb 1, 2025
Yarik-Popov
Yarik-Popov requested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good start. Some changes are needed

@Yarik-Popov
Copy link
Contributor

Backend lgtm. If you want to start working on a backend task rn, dm me your email and ill add you to the notion. Otherwise if you want to wait until you are done the frontend that also works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarik-Popov Yarik-Popov Yarik-Popov requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FxJYg @Yarik-Popov