Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook webpack autobuild no longer works with storybook-design-token options #170

Open
Kavallier opened this issue Jun 22, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@Kavallier
Copy link

Hi.
I've recently implemented the design tokens, thanks to your help, and everything looks great.
I'm noticing however that when I change a file (scss/js) the Storybook webpack build no longer happens automatically.
When I comment out the following lines, autobuild happens successfully again.

{
  name: "storybook-design-token",
  options: {
    designTokenGlob: "**/*_tokens.scss"
  }
}

Have you ever seen this before, and would you know how to resolve?

@Kavallier Kavallier reopened this Jun 23, 2023
@lukethacoder
Copy link

Ran into a similar issue. Managed to get it working by not defining the designTokenGlob here but instead in an .env file.

DESIGN_TOKEN_GLOB=**/*_tokens.scss

@Sqrrl
Copy link
Collaborator

Sqrrl commented Jun 27, 2023

Thanks for the insight. I will have a look at it.

@Kavallier
Copy link
Author

Thank you. I’ll try it out

@Kavallier
Copy link
Author

Seems to be related to the glob configuration. Won't autobuild on any scss file change, other than the one defined in designTokenGlob, but will autobuild on any other filetype change.

@Sqrrl
Copy link
Collaborator

Sqrrl commented Jul 27, 2023

I will look into this. Can you confirm that the issue doesn't occur when using the DESIGN_TOKEN_GLOB env var?

@Sqrrl Sqrrl added the bug Something isn't working label Jul 27, 2023
@Kavallier
Copy link
Author

Issue still occurs for me even with the env variable

@ankuragarwalait
Copy link

ankuragarwalait commented Mar 12, 2024

@Sqrrl Any update on this.. Have the same issue with
{ name: "storybook-design-token", options: { designTokenGlob: "**/*_tokens.scss" } }

Did observe an error in the browser console. Not sure if related but thought might be worth putting out here.

Screenshot 2024-03-13 at 5 34 26 am

@Kavallier Did the autobuild work for you for other JS changes you make. For me none of it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants