NuGetSources task #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluck
reviewed
Jan 2, 2018
| @@ -27,6 +27,11 @@ class NuGetPlugin implements Plugin<Project> { | |||
| group = BasePlugin.UPLOAD_GROUP | |||
| description = 'Pushes the NuGet package to the configured server url.' | |||
| } | |||
|
|
|||
| project.task('nugetSources', type: NuGetSources) { | |||
| group = BasePlugin.UPLOAD_GROUP | |||
There was a problem hiding this comment.
probably this operation shouldn't be part of the upload group, you can probably remove the group entirely if there's no fitting/existing one
There was a problem hiding this comment.
Ok, I have removed the group.
gluck
reviewed
Jan 3, 2018
| if (sourceName) args '-Name', sourceName | ||
| if (sourceUrl) args '-Source', sourceUrl | ||
| if (username) args '-UserName', name | ||
| if (password) args '-Passsword', name |
There was a problem hiding this comment.
Yes, sorry about that. Should be OK now.
gluck
reviewed
Jan 4, 2018
| args operation | ||
| if (sourceName) args '-Name', sourceName | ||
| if (sourceUrl) args '-Source', sourceUrl | ||
| if (username) args '-UserName', name |
gluck
reviewed
Jan 4, 2018
| if (sourceName) args '-Name', sourceName | ||
| if (sourceUrl) args '-Source', sourceUrl | ||
| if (username) args '-UserName', name | ||
| if (password) args '-Passsword', password |
There was a problem hiding this comment.
typo still (-Passs vs -Pass)
gluck
reviewed
Jan 4, 2018
| if (username) args '-UserName', name | ||
| if (password) args '-Passsword', password | ||
| if (configFile) args '-ConfigFile', configFile | ||
| if (storePaswordInClearText) args '-StorePaswordInClearText' |
|
Sorry about that. Typos fixed. |
gluck
reviewed
Jan 5, 2018
| if (sourceName) args '-Name', sourceName | ||
| if (sourceUrl) args '-Source', sourceUrl | ||
| if (username) args '-UserName', username | ||
| if (password) args '-Passsword', password |
There was a problem hiding this comment.
Still the '-Passs' typo here, no ?
|
Yes, I have fixed that one now, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added task for nuget sources command.