You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we import anything like "from comet import load_from_checkpoint" it will create a global variable "logger" and there are consequences if in the main code calling this import we also have a variable "logger".
Since the likelihood is more "calling comet from another toolkit" rather than the contrary, I would like to rename the logger variable to comet_logger which has to happen only in a few instances.
Do you agree?
The text was updated successfully, but these errors were encountered:
The point lies here: https://github.com/Unbabel/COMET/blob/master/comet/__init__.py#L22
When we import anything like "from comet import load_from_checkpoint" it will create a global variable "logger" and there are consequences if in the main code calling this import we also have a variable "logger".
Since the likelihood is more "calling comet from another toolkit" rather than the contrary, I would like to rename the logger variable to comet_logger which has to happen only in a few instances.
Do you agree?
The text was updated successfully, but these errors were encountered: