-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display proper GM version in the window title #929
Comments
Personally think that the approximate version should be shown in General Info (or in a another new tab?) rather than the title along with all the other extra stuff that currently isn't shown like |
In my opinion, the data.win version is less useful than the approximation - the approximation being in the window title would help with easily spotting which GM versions the tool's having issues with. I like your idea of showing the hidden variables in a separate tab, and personally think the (now not-updated) data.win version should be moved there. |
Well, if a game fails to load, then the window title won't even get a chance to update. If a game fails to save or other errors occur, then I don't think its that hard to ask for people to send what the variable is by looking at a certain tab.
The general info, options and language areas are all sorted by their respective chunks. Moving the version which is part of GEN8 out of the area that displays GEN8 info is not good UX. |
Why is this even the case? The tool doesn't allow these values to be edited, and as far as I know no-one has ever actually used them. |
The tool does allow all of the values to be edited (except for language, that one needs to be edited via lib). |
My experience is that past GMS1.x that number only serves to confuse people. I have a script around that uses the fields in Data to tell the user what the approximate version is, and it's seeing a lot of use by the people testing titles on the yoyoloader compatibility list, so I'm upvoting Archie here. |
When looking at the window title or the general info? |
This would be the worst UX imaginable. Someone could miss that notice, and then when asking for help be adamant their version is different from what it actually is. |
Most users aren't looking at the general info tab to get their game's version. I assume the general info would have the warning and the window title would just have the more accurate version. Relevant files for changing the title:
|
Yeah, meant this if it wasn't clear. Just have big red text under the 2.0.0.0 version box saying a warning for that.
Why are they stored in UndertaleData to begin with? Wouldn't it be better to move them to GeneralInfo and make them an Enum, so that it isn't possible to do i.e. |
They're stored in the Data because GeneralInfo corresponds to an actual chunk, and the 2.2+ flags aren't stored in GeneralInfo. They're deduced from the way the file is parsed. An Enum could work. Just as long as they're in the right order. |
There are several instances where variables are put into the chunk / Model that makes the most sense, but aren't actually part of the data file and instead an UMT-exclusive variable. |
Which component should be improved?
UI/UX
Describe your feature suggestion in more detail
Currently, even the latest DELTARUNE Chapter 2 builds show up as GMS 2.0.0.0 - I understand this is the version that UMT reads directly from the data.win, but given we can identify if a game uses 2022.x accurately, it should in my opinion be displayed instead.
Even if we can't identify all of the versions separately (as maybe the WAD format didn't change), the window title should include at least an approximation of what the version might be (think
GM2022.3+
).The text was updated successfully, but these errors were encountered: