fix importing collision event files when the objects already exist #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miepee
approved these changes
Nov 11, 2023
|
Cannot recall the reason that code was there, so for now I'll merge this. If anything else is affected, we'll find out quickly enough. |
|
Download the artifacts for this pull request here: GUI:
CLI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you try using the
ImportGMLFilefor a collision event, for example, for a file namedgml_Object_obj_pipis_bullet_cone_Collision_obj_yheart_shot.gml, and tried to link to the objects automatically, even if the objects in the event already existed, it would require you to type the object, despite it already knowing it. With this fix, this issue is removed.Caveats
In my tests, it worked perfectly. I'm not sure why the original code that caused this problem existed, so unless it had any special reason to be there, there should be no problems with this change.