Correct function definitions and 2.3 FancyRoomSelect #921
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
UndertaleModLib/Compiler/Parser.cs
Outdated
| return result; | ||
| if (expression) | ||
| return result; | ||
| else // Whatever you call non-anonymous |
There was a problem hiding this comment.
Else is unnecessary here, due to the return from above.
There was a problem hiding this comment.
I feel that keeping both returns on the same level makes it clear at a glance that neither is especially a "default". You can't miss the if anymore and assume it always does the one thing.
There was a problem hiding this comment.
Which is fair, I just dislike the nesting. Probably a better thing to have in this case though.
|
So, the reason why struct decompilation uses |
|
Oh, that worked pretty well. No more conflicts, right? |
Description
Adds support for
function scr_myscript()formatting in GMS 2.3+ in both compilation and decompilation. Minor tweaks to FancyRoomSelect.csx to function on 2.3+ with strange room orders.Caveats
Struct definition isn't 100% due to me not knowing how struct definition works. The new decompiler code hackily uses
FunctionDefinitionas both an Expression and a Statement depending on context. The code does not differentiate in decompilation;scr_myscript = function()no longer appears even if it is the format used, although it is still accepted in compilation.I didn't bother to restrict the
myroom_lastvariable to 2.3, so technically it defines one additional unused variable when the script is used on older games. This will not cause performance issues.Notes
Closes #926. Closes #951.