New grid related features #931

plrusek · 2022-05-25T01:23:12Z

Description

The grid now has been moved from being rendered in the background of the canvas (meaning it could be covered up by any room object easily) to the foreground of the canvas (meaning it will render on top of everything), thanks to the use of an opacity mask on the canvas.
The automatically calculated grid height and width per room (based on the width and height of the most used tile in said room) can now be overriden by global properties that can be enabled/disabled and then set in the settings.
The settings window itself had a slight reordering of it's contents (slighty tidyup, empty horizontal space was filled out)

…on trees

… Tab focus on object list in rooms when clicking on something

… the automatic grid calculation (from most used tile in a room). Moved the grid from background to foreground (thanks to OpacityMask). Adjusted the settings menu layout a bit. Room thickness is 0.5 by default now.

…expression trees" This reverts commit 829cdb4.

github-actions · 2022-05-25T01:27:32Z

Download the artifacts for this pull request here:

GUI:

CLI:

UndertaleModTool/Editors/UndertaleRoomEditor.xaml

Add empty lines back in Co-authored-by: VladiStep <vlad2001.21@mail.ru>

VladiStep · 2022-05-25T16:29:02Z

UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs

@@ -832,6 +832,7 @@ private void SelectObject(UndertaleObject obj)

                resListView.IsExpanded = true;
                resListView.BringIntoView();
+                resListView.Focus();


It should be after line 856 (resItem.IsSelected = true;).

Miepee · 2022-05-25T16:56:21Z

UndertaleModTool/MainWindow.xaml.cs

@@ -1478,7 +1478,7 @@ private void TreeView_SelectedItemChanged(object sender, RoutedPropertyChangedEv

        private void MainTree_MouseDoubleClick(object sender, MouseButtonEventArgs e)
        {
-            OpenInTab(Highlighted);
+            OpenInTab(Highlighted, true);


This change is not mentioned on the PR description.
I personally do not like everything opening in a new tab.

Miepee · 2022-05-25T17:03:05Z

UndertaleModLib/Models/UndertaleRoom.cs

@@ -403,11 +403,18 @@ public void SetupRoom(bool calculateGrid = true)
            }

            // If tiles exist at all, grab the most used tile size and use that as our grid size
+            // If a default starting grid is set in the settings, use that instead


This comment is slightly misleading, as in this code block the starting grid is not get from the settings as the grid isn't even recalculated in that case.

UndertaleModLib/Models/UndertaleRoom.cs

UndertaleModTool/Editors/UndertaleRoomEditor.xaml.cs

UndertaleModLib/Models/UndertaleRoom.cs

Miepee · 2022-05-25T17:53:16Z

Input boxes need some work:

I can add a lot of numbers here
As mentioned in the comments from above, only setting height currently does not work as expected.
For a better user experience, it would be better if one couldn't input normal text in there
Default grid sizes should probably be 20x20 instead of 0x0
Setting negative grid sizes crashes the room editor
putting too high or too low numbers shows an error message. Would be better if a user couldn't input them in the first place, or if the numbers would be snapped to what makes sense (aka ]0;Int32.MaxInt])
same as above but with NaN and -NaN
-0 is apparently a valid grid size
Having thickness be enforceable via settings would also be nice
~~Exporting the room as a PNG exports the grid as well which is undesirable.~~ EDIT: Nevermind, seems that it is actually desirable considering that the ExportAllRoomsToPNG script asks whether or not to draw the grid.

…grid changes to UndertaleRoomRenderer. Condensed some if statements. Reverted default grid thickness.

VladiStep · 2022-05-29T16:17:02Z

UndertaleModTool/Controls/UndertaleRoomRenderer.xaml

+                            <DrawingBrush TileMode="Tile" ViewportUnits="Absolute">
+                                <DrawingBrush.Viewport>
+                                    <MultiBinding Converter="{StaticResource GridConverter}">
+                                        <Binding Path="GridWidth" Mode="OneWay"/>


All the data bindings that you've changed/added should be OneTime.

Miepee · 2022-06-20T13:27:32Z

Vlad brought up something in the server which I think is worth noting here.
Currently, with the revamped settings, columns are a bit hard to distinguish.

Something that could help with this, would be to move the checkboxes before the text, similar to how other tools do it. (using JBRider here as an example:)

The above path textboxes can be left as-is, but the textboxes for width/height should be then also rearranged to have the activation checkbox on the left, with the textbox on the right like here:

Miepee · 2022-06-30T18:37:51Z

Thanks for the PR! Unfortunate, that you weren't able to get this one merged and that we needed to create our own PRs for it, but nevertheless your contributions are very welcomed :)

Grossley · 2022-06-30T19:50:17Z

No longer necessary.

plrusek added 7 commits April 22, 2022 21:24

added UndertaleObject duplicating with deep copies thanks to expressi…

829cdb4

…on trees

Merge branch 'master' of https://github.com/plrusek/UndertaleModTool

cbd06f7

changed default behavior or double clicking anything to open in a new…

c2c8390

… Tab focus on object list in rooms when clicking on something

Merge branch 'krzys-h:master' into master

c29b1c2

Revert "added UndertaleObject duplicating with deep copies thanks to …

22e85c0

…expression trees" This reverts commit 829cdb4.

Clean up accidental commit of useless converter

9788734

Revert messed up line endings

6aa36e0

VladiStep requested changes May 25, 2022

View reviewed changes

UndertaleModTool/Editors/UndertaleRoomEditor.xaml Outdated Show resolved Hide resolved

UndertaleModTool/Editors/UndertaleRoomEditor.xaml Outdated Show resolved Hide resolved

Apply suggestions from code review

047c815

Add empty lines back in Co-authored-by: VladiStep <vlad2001.21@mail.ru>

VladiStep reviewed May 25, 2022

View reviewed changes

Miepee reviewed May 25, 2022

View reviewed changes

plrusek added 2 commits May 25, 2022 20:38

Fixed broken height and width assignment logic. Added the foreground …

c37878b

…grid changes to UndertaleRoomRenderer. Condensed some if statements. Reverted default grid thickness.

Merge branch 'master' of https://github.com/plrusek/UndertaleModTool

2a9084f

VladiStep reviewed May 29, 2022

View reviewed changes

This was referenced Jun 24, 2022

Make Settings window more compact #998

Merged

Make room grid be in front, instead of in back #1001

Merged

Add global grid width, height and thickness settings #1005

Merged

VladiStep mentioned this pull request Jun 29, 2022

Easier deletion of a room object. #1019

Merged

Grossley closed this Jun 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New grid related features #931

New grid related features #931

plrusek commented May 25, 2022

github-actions bot commented May 25, 2022 •

edited

Loading

VladiStep May 25, 2022

Miepee May 25, 2022

Miepee May 25, 2022

Miepee commented May 25, 2022 •

edited

Loading

VladiStep May 29, 2022

Miepee commented Jun 20, 2022

Miepee commented Jun 30, 2022

Grossley commented Jun 30, 2022

New grid related features #931

New grid related features #931

Conversation

plrusek commented May 25, 2022

Description

github-actions bot commented May 25, 2022 • edited Loading

VladiStep May 25, 2022

Choose a reason for hiding this comment

Miepee May 25, 2022

Choose a reason for hiding this comment

Miepee May 25, 2022

Choose a reason for hiding this comment

Miepee commented May 25, 2022 • edited Loading

VladiStep May 29, 2022

Choose a reason for hiding this comment

Miepee commented Jun 20, 2022

Miepee commented Jun 30, 2022

Grossley commented Jun 30, 2022

github-actions bot commented May 25, 2022 •

edited

Loading

Miepee commented May 25, 2022 •

edited

Loading