Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow entries from the left list to be middle-mouse button'ed #983

Closed
wants to merge 1 commit into from

Conversation

Miepee
Copy link
Contributor

@Miepee Miepee commented Jun 16, 2022

Description

This PR makes it so that entries from the left list can be middle-mouse button'ed, which opens them in another tab.
Fixes #981

Caveats

  • If you attempt to MMB the headers, they won't get highlighted, which may look a little weird
  • MMB'ing results in the treeview centering the item that was clicked, which may look a little weird.

@VladiStep
Copy link
Member

Besides the caveats you've described, there are more issues:

  1. The MouseDown handler is MainTree_OnMouseDown(), but it's assigned to every child of TreeViewItem.
  2. It doesn't check the UndertaleRoom layers order that you are opening.
  3. It doesn't open UndertaleString items.

@Miepee
Copy link
Contributor Author

Miepee commented Jun 16, 2022

The MouseDown handler is MainTree_OnMouseDown(), but it's assigned to every child of TreeViewItem.

It is supposed to be assigned to the TreeViewItem children. The name is completely wrong, because it was from when I was still figuring things out which I later forgot to update xP

@Miepee
Copy link
Contributor Author

Miepee commented Jun 17, 2022

Closed in favour of #988

@Miepee Miepee closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make MMB on assets open them in new tabs
2 participants