Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(token lists): implement the uniswap default list as a token list #983

Merged
merged 29 commits into from
Jul 25, 2020

Conversation

moodysalem
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/bega2adgh
✅ Preview: https://uniswap-interface-git-token-list.uniswap.vercel.app

Copy link
Contributor

@NoahZinsmeister NoahZinsmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM so far

ideally we'd be able to avoid using unpkg for the default list, and instead be able to resolve the list over IPFS via a contenthash record on an ENS name or directly via IPNS (+DNSLink), but it's not necessarily a blocker

@moodysalem
Copy link
Contributor Author

generally LGTM so far

ideally we'd be able to avoid using unpkg for the default list, and instead be able to resolve the list over IPFS via a contenthash record on an ENS name or directly via IPNS (+DNSLink), but it's not necessarily a blocker

agreed, Uniswap/default-token-list#2

@moodysalem moodysalem marked this pull request as ready for review July 23, 2020 16:32
@moodysalem moodysalem marked this pull request as draft July 23, 2020 16:34
@moodysalem
Copy link
Contributor Author

forgot imported tokens...

@vercel vercel bot temporarily deployed to Preview July 23, 2020 22:34 Inactive
@moodysalem moodysalem marked this pull request as ready for review July 23, 2020 22:57
@moodysalem moodysalem merged commit 365b429 into master Jul 25, 2020
@moodysalem moodysalem deleted the token-list branch July 25, 2020 15:41
crisog pushed a commit to Levinswap/levinswap-interface that referenced this pull request Feb 5, 2021
…Uniswap#983)

* load tokens from url `useTokenList`

* improve performance of the loading

* move the loading to redux and save loaded lists

* lint error

* move the list fetching code to a separate component

* change how token lists are fetched to use the updater and add unit tests

* fix a crash with currencyEquals

* bump sdk version

* token lists should automatically update for minor/patch changes

* nit

* show popups for list updates

* support pointing at localhost

* spuport ipfs/ipns logos

* use the updater to bump list versions

* save the old/new list in the popup for viewing diffs

* improve the list popup

* fix linter error, make sure visibility checking is working

* show list update notifications

* address a couple metamask warnings, linter error

* fix the custom added/default tokens

* refactor some popup stuff to reuse the fader

* linter error

* Revert: refactor some popup stuff to reuse the fader (a7b0f75)

* style improvements, linter

* add to the readme, drop the token-request template

* back to the beta that works with wallet connect

* get the dependencies to a state that works with wallet connect and passes integration tests
daniel-dev1990 pushed a commit to daniel-dev1990/uniswap-interface that referenced this pull request Jul 8, 2021
…Uniswap#983)

* load tokens from url `useTokenList`

* improve performance of the loading

* move the loading to redux and save loaded lists

* lint error

* move the list fetching code to a separate component

* change how token lists are fetched to use the updater and add unit tests

* fix a crash with currencyEquals

* bump sdk version

* token lists should automatically update for minor/patch changes

* nit

* show popups for list updates

* support pointing at localhost

* spuport ipfs/ipns logos

* use the updater to bump list versions

* save the old/new list in the popup for viewing diffs

* improve the list popup

* fix linter error, make sure visibility checking is working

* show list update notifications

* address a couple metamask warnings, linter error

* fix the custom added/default tokens

* refactor some popup stuff to reuse the fader

* linter error

* Revert: refactor some popup stuff to reuse the fader (a7b0f75)

* style improvements, linter

* add to the readme, drop the token-request template

* back to the beta that works with wallet connect

* get the dependencies to a state that works with wallet connect and passes integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants