Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak in Fst2List #102

Merged
merged 1 commit into from
Jun 16, 2020
Merged

fix memory leak in Fst2List #102

merged 1 commit into from
Jun 16, 2020

Conversation

JM-ERI
Copy link
Contributor

@JM-ERI JM-ERI commented Jun 15, 2020

Description

Solve the issue #87.
resolve a memory leak in the current solution.

Motivation and Context

Without this change, the output file of explore graph paths is not readable for Korean users.
It fixes a memory leak that occurs in the code

How Has This Been Tested?

This change has been tested on some graphs in korean.
korean_tests_graphs.zip
tested locally with unitex-core-test.

Screenshots (if appropriate):

Type of files

  • bin: Binary files
  • ci: Continuous integration files
  • doc: Documentation files
  • Plain-text source code files

Level of change

  • break: Breaking change
  • exp: Experimental change
  • tmp: Temporal change
  • major: Major change
  • minor: Minor change
  • sec: Vulnerability-related change
  • None of the above (normal change)

Type of change

  • deprecat: Deprecation of a once-stable feature
  • enhance: Enhancement in existing functionality
  • fix: Bug fix
  • feature: New feature
  • hotfix: Hotfix for bugs
  • refactor: Improve coding style, comments
  • remove: Remove a feature

Checklist:

  • My code compiles
  • My code follows the code style of this project
  • My code includes javadoc/doxygen where appropriate
  • My code is well factored, so that there is not repetitive code in the wild
  • My code does not require a change in the documentation, if so I already opened an issue to list the changes
  • I have read the CONTRIBUTING document
  • I have read the Commit Message Guidelines
  • I understand that all commits on my pull request will be squashed to a single good one

@pullapprove pullapprove bot requested a review from martinec June 15, 2020 11:31
Copy link
Member

@martinec martinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@martinec martinec merged commit c22e9d2 into UnitexGramLab:master Jun 16, 2020
martinec pushed a commit that referenced this pull request Aug 9, 2021
This commit resolves a minor memory leak in Fst2List that 
was introduced with #87

See also #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants