fixed bug where record duration settings in seconds was not correctly applying time start offset.

Author: jasonm-unity

source/FrameRecorder/Core/Engine/Recorder.cs

@@ -96,7 +96,7 @@ public virtual void PrepareNewFrame(RecordingSession ctx)
 
         public virtual bool SkipFrame(RecordingSession ctx)
         {
-            return !recording || (ctx.m_FrameIndex % settings.m_CaptureEveryNthFrame) != 0;
+            return !recording || (ctx.m_FrameIndex % settings.m_CaptureEveryNthFrame) != 0 || ctx.m_CurrentFrameStartTS < settings.m_StartTime;
         }
 
         public bool recording { get; protected set; }

source/FrameRecorder/Core/Engine/RecorderComponent.cs

@@ -19,7 +19,7 @@ public void Update()
         {
             if (session != null && session.recording)
             {
-                session.m_CurrentFrameStartTS = (Time.time / Time.timeScale) - session.m_RecordingStartTS;
+                session.m_CurrentFrameStartTS = Time.unscaledTime - session.m_RecordingStartTS;
                 session.m_FrameIndex++;
 
                 session.PrepareNewFrame();
@@ -45,9 +45,20 @@ IEnumerator RecordFrame()
                             enabled = false;
                         break;
                     case DurationMode.TimeInterval:
+                    {
+                        if (session.settings.m_FrameRateMode == FrameRateMode.Variable)
+                        {
                         if (session.m_CurrentFrameStartTS >= session.settings.m_EndTime)
                             enabled = false;
+                        }
+                        else
+                        {
+                            var expectedFrames = (session.settings.m_EndTime - session.settings.m_StartTime) * session.settings.m_FrameRate;
+                            if (session.RecordedFrameSpan >= expectedFrames)
+                                enabled = false;
+                        }
                         break;
+                    }
                 }
             }
         }

source/FrameRecorder/Core/Engine/RecordingSession.cs

@@ -15,18 +15,24 @@ public class RecordingSession : IDisposable
         public int m_FrameIndex; // count starts at 0.
         public double m_CurrentFrameStartTS;
         public double m_RecordingStartTS;
-
         int     m_InitialFrame = 0;
+        int     m_FirstRecordedFrameCount = -1;
         float   m_FPSTimeStart;
-
         float   m_FPSNextTimeStart;
         int     m_FPSNextFrameCount;
 
         public RecorderSettings settings { get { return m_Recorder.settings; } }
         public bool recording { get { return m_Recorder.recording; } }
 
+        public int RecordedFrameSpan
+        {
+            get { return m_FirstRecordedFrameCount == -1 ? 0 : Time.renderedFrameCount - m_FirstRecordedFrameCount; }
+        }
+
         public bool BeginRecording()
         {
+            m_RecordingStartTS = Time.unscaledTime;
+
             if (!m_Recorder.BeginRecording(this))
                 return false;
             m_InitialFrame = Time.renderedFrameCount;
@@ -49,6 +55,8 @@ public void RecordFrame()
             {
                 m_Recorder.RecordFrame(this);
                 m_Recorder.recordedFramesCount++;
+                if (m_Recorder.recordedFramesCount == 1)
+                    m_FirstRecordedFrameCount = Time.renderedFrameCount;
             }
             m_Recorder.SignalSourcesOfStage(ERecordingSessionStage.FrameDone, this);
 

source/FrameRecorder/Core/Engine/Timeline/FrameRecorderClip.cs

@@ -35,7 +35,6 @@ public override Playable CreatePlayable(PlayableGraph graph, GameObject owner)
                 {
                     m_Recorder = RecordersInventory.GenerateNewRecorder(recorderType, m_Settings),
                     m_RecorderGO = FrameRecorderGOControler.HookupRecorder(),
-                    m_RecordingStartTS = Time.unscaledTime,
                     m_FrameIndex = 0
                 };
             }

source/FrameRecorder/Core/Engine/Timeline/RecorderPlayableBehaviour.cs

@@ -65,7 +65,6 @@ public override void OnBehaviourPlay(Playable playable, FrameData info)
                 return;
 
             // Assumption: OnPlayStateChanged( PlayState.Playing ) ONLY EVER CALLED ONCE for this type of playable.
-            session.m_RecordingStartTS = Time.unscaledTime;
             m_PlayState = PlayState.Playing;
         }