Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compass asset load in standalone builds #286

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Chootin
Copy link

@Chootin Chootin commented Jun 14, 2022

I confirmed the previous version of the code would not work in Unity version 2021.2.18f1 - the default would end up being used instead.

Proposed change(s)

Loading the resources asset with the name rather than the name and file extension.

Types of change(s)

  • [ x ] Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

Created a script which would move an asset when it receives a pose message from ROS. I performed the test in the editor and noted a different result from the build. After connecting a debugger it was apparent the asset wasn't being loaded.

Test Configuration:

  • Unity Version: Unity 2021.2.18f1
  • Unity machine OS + version: Ubuntu 18.04
  • ROS machine OS + version: Ubuntu 18.04, ROS Melodic
  • ROS–Unity communication: Local

Checklist

  • [ x ] Ensured this PR is up-to-date with the dev branch
  • [ x ] Created this PR to target the dev branch
  • [ x ] Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

I confirmed the previous version of the code would not work in Unity version 2021.2.18f1 - the default would end up being used instead.
@unity-cla-assistant
Copy link

unity-cla-assistant commented Jun 14, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants