Swap bytes for tcp port number (case 1165578) #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we do the IP6 data structures as well? |
joncham
approved these changes
Jul 31, 2019
|
I looked at the output to console for the IPv6 values yesterday and I "think" they looked ok. I'll toss a breakpoint in there to verify a bit more confidently today before I merge this. |
UnityAlex
force-pushed
the
fix-windows-tcp-portnumbers
branch
from
417503f
to
d8025cb
Compare
|
After using a breakpoint to inspect I verified that the IPv6 structs (classes) need the byte swap too so I've added it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: Port numbers returned from GetActiveTcpConnections on Windows are now correct.