Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big blind commit #1313

Open
wants to merge 931 commits into
base: unity-main
Choose a base branch
from
Open

Conversation

midopooler
Copy link

@midopooler midopooler commented Jul 4, 2020

.

ashwinimurt and others added 30 commits May 17, 2019 10:19
The `IDataContractSurrogate` interface is part of the public API of
.NET 4.7.1. In has a method named `ProcessImportedType`, which was not
compiled into the unityaot profile.

The `ProcessImportedType` method uses types `CodeTypeDeclaration` and
`CodeCompileUnit` as parameters. Both of these types are pretty large,
and we don't want to compile them into the unityaot profile.

So in order to compile the `ProcessImportedType` method method, add
empty `CodeTypeDeclaration` and `CodeCompileUnit` types in unityaot (the
profile stubber will fill these in properly). This change allows the
unstripped unityaot profile work correctly with IL2CPP.

It is difficult for the profile stubber to handle this case, because
the code in `SurrogateProviderAdapter` is in a facade assembly, which
the profile stubber currently ignores.
…d-mising-codedom-unityaot

Compile ProcessImportedType in IDataContractSurrogate for unityaot
Specifically, this picks up changes from:

https://github.cds.internal.unity3d.com/unity/il2cpp/pull/287

although there are earlier changes that were not synced here as well.
…nc-debugger-from-il2cpp-2

Sync the debugger agent code from IL2CPP
Use actual stack fault address rather than relying on the
SP of the current frame. If we try to enter a method with a
large prolog (many locals) we may try to allocate more stack
than is available, however the SP has not been updated. This
means the stack overflow heuristic to free up enough space
may fail, as the used stack may be smaller than the amount
of stack that was attempted to be unwound.
…x-builds-zip-permissions

Don't re-zip artifact
…ort socket is opened after stopping the debugger thread and start a new debugger thread
The default value for `DefaultConnectionLimit`, which is set based on
the `DefaultPersistentConnectionLimit` value should be 2 for all
non-ASP.NET applications.

So for the unityaot profile, used with IL2CPP, use the value of 2.
…ange-default-connection-limit

Use the non-server default connection limit for unityaot (case 1156607)
…ity-master-liveness-depth

Fix liveness recursion issue (case 1137077). Cherry-pick of https://g…
…ity-master-debugger-async-crash

Fix crash during async debugging (case 1153078). Apply partial patch …
…ity-master-stack-overflow-windows-sp-address

Update RSP with fault address for stack overflow (case 1148592)
…ity-master-debugger-perf

Initial work to allow debugger attaching without performance impact.
This change builds the class library code to implement the
`NamedPipeClientStream` class in the unityaot profile on Windows. For
the time being, we will not implement this class for non-Windows
platforms, since that requires the Mono.Posix.dll assembly and a native
library as well.

We may consider adding support on Posix platforms in the future.
…med-pipes-unityaot

Implement NamedPipeClientStream in the unityaot profile (case 1159863)
…ity-master-fix-wsl

Correct call to bootstrap script for wsl build
joncham and others added 26 commits June 7, 2020 09:03
…ackwalking-handle-null-ip

Gather callstack even if instruction pointer is null.
…3373)

* [debugger] Fixing two crashes while debugging an Android app.

-> Doing stepping into in VSM in some situation the frame saved in TLS is not synchronised with what is really been executed in the main thread. This makes the debugger-agent crashes because it tries to get variable info in some memory that is not available anymore.
	-> To fix it I forced the update of stack when CMD_THREAD_GET_FRAME_INFO is called.

-> Doing step over in Visual Studio for Windows, if you have the threads debugger window enabled, VSW calls frame_commands for each thread that is showed, and if the thread is not really_suspended it tries to get variable info from a memory that is not available anymore because the thread is not suspended yet.
	-> To fix it I don't send variable info of a frame if the thread is not really_suspended and doesn't have an async_state valid.

Cherry-picked with some light massaging by Alex Thibodeau (case 1249172)
…ity-master-fix-1249172

[debugger] Fixing two crashes while debugging an Android app. (mono#13373) (unity case 1249172)
This change applies a similar fix for exFAT partitions as was applied
for FAT32 partitions earlier. For exFAT partitions, the invalid inode
value seems to be 1 though.
…x-exfat-file-sharing

Correct file sharing for exFAT partitions on macOS (case 1253812)
Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
…undefined on darwin but was added recently which leads to unexpected behavior

Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
Signed-off-by: Tautvydas Žilys <tautvydas.zilys@gmail.com>
…c-arm64

Add Apple silicon slice to Mono runtime built for macOS
…e data in the windows registry. (case 1256569)
…ity-master-fix-1256569

Fixing a hang that would occur when there is incorrectly set time zon…
…e-retries

Retry running bee several times if it fails
…ity-master-fix-bdwgc-perf-regression

Pickup BDWGC fix for GC_retry_signals performance regression (case 1255866)
@unity-cla-assistant
Copy link
Collaborator

unity-cla-assistant commented Jul 9, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 11 committers have signed the CLA.

✅ midopooler
✅ ashwinimurt
✅ UnityAlex
✅ scott-ferguson-unity
❌ TautvydasZilys
❌ thaystg
❌ jechter
❌ unpacklo
❌ Joe Valenzuela
❌ GeoffroyAubey
❌ kumpera


Joe Valenzuela seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@midopooler midopooler changed the title fixed typo big blind commit Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.