2021.3: Correct the behavior of named pipes on Windows platforms. #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1192 we added support for named pipes on Windows previously. This support failed to work with the unityaot-win32 profile after the most recent Mono upgrade. With this change, we will also add tests to IL2CPP to ensure that this does not break again.
joshpeterson
approved these changes
May 11, 2022
jhcdunity3d
approved these changes
May 11, 2022
achavakula-rythmos
deleted the
unity-2021.3-mbe-named-pipes-unityaot-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1192 we added support
for named pipes on Windows previously. This support failed to work with
the unityaot-win32 profile after the most recent Mono upgrade.
With this change, we will also add tests to IL2CPP to ensure that this
does not break again.
Reviewers: please consider these questions as well! ❤️
Fixed case 1420995 @achavakula-rythmos :
IL2CPP: Correct the behavior of named pipes on Windows platforms.
Comments to reviewers:
Cherry picked changes from the Trunk PR : #1615
Cherry pick is [CleanGraft]