-
Notifications
You must be signed in to change notification settings - Fork 79
[USDU-276] Adds testcase for Force Refreshing USDZ Imported prefab with Import Preview Surface option #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f33d997 to
95bc711
Compare
vickycl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely clear what the goal of this test is. I think this test (and the bug) are more about the ImportPreviewSurface than the reload behaviour, is that correct? If so, I think this test should be moved to a material specific file, and/or make that more clear in the test. In its current state it's not clear to me what additional value this test adds.
Hey Vicky, the goal of this test is to make sure that error handling is done correctly when Refresh errors out with the testing circumstances stated during the test - and as far as i know the steps taken in the test case is the only way a user may refresh a usdz imported prefab with Import Preview Surface without having to bring it into the Unity Scene The same error does not happen when you directly import it as a prefab with the Scene Import Options with materials set to ImportPreviewSurface (have to temporarily change setting in ImportHelpers.ImportAsPrefab) so it seems like a problem with the Refresh feature more than specifically the ImportPreviewSurface setting Though I do agree I havent been too descriptive in the naming of the test case, I changed it to |
vickycl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DM'd on Slack, I think this test should probably be two based on reproducing the original bug :)
package/com.unity.formats.usd/Tests/Editor/UsdAssetReloadTests.cs
Outdated
Show resolved
Hide resolved
…th Import Preview Surface option
4676690 to
ee0ec86
Compare
vickycl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new tests look much clearer :)
|
Thanks for the reviews @vickycl ! |
Purpose of this PR
Ticket/Jira #:
USDU-276
Testing
Adds testcase for Force Refreshing a USD prefab imported from a USDZ file, with Import Preview Surface option set for "Materials"
Is currently ignored as it will cause a failure due to USDU-276
Overall Product Risks
Complexity:
1
Halo Effect:
1