Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find variable: DOMException (React Native) #221

Closed
ibrahimchraibi opened this issue Jul 18, 2024 · 3 comments
Closed

Can't find variable: DOMException (React Native) #221

ibrahimchraibi opened this issue Jul 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ibrahimchraibi
Copy link

Describe the bug

Hello :)

We are currently using @unleash/proxy-client-react & unleash-proxy-client in our React Native project, according to the documentation React Native platform should be supported, but this exception started popping due to this line:

if (!(e instanceof DOMException && e.name === 'AbortError')) {

Which makes sense since DOMException is browser specific.

Are we missing something? Wouldn't be enough to check for the exception name?

Thank you very much for your answer and for the solid work on this awesome project!

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

ReferenceError <unknown>(unleash-proxy-client/build/main)
Level: Error
Can't find variable: DOMException

Screenshots

No response

Additional context

No response

Unleash version

No response

Subscription type

Open source

Hosting type

Self-hosted

SDK information (language and version)

@unleash/proxy-client-react (React Native)

@kwasniew
Copy link
Contributor

Hi @ibrahimchraibi ! Thanks for the report. We fixed this issue here: #222
Next week we'll release a new version and bump up React SDK

@chriswk chriswk moved this from New to In Progress in Issues and PRs Jul 22, 2024
thomasheartman added a commit to Unleash/proxy-client-react that referenced this issue Jul 22, 2024
This updates the JS SDK dependency to 3.5.2, which contains a fix for
an [issue with React Native, where DOMExceptions don't exist](Unleash/unleash-proxy-client-js#221).
thomasheartman added a commit to Unleash/proxy-client-react that referenced this issue Jul 22, 2024
This updates the JS SDK dependency to 3.5.2, which contains a fix for
an [issue with React Native, where DOMExceptions don't exist](Unleash/unleash-proxy-client-js#221).
@thomasheartman
Copy link
Contributor

Hey, @ibrahimchraibi! We've released updated versions of both the JS SDK (v3.5.2) and the React SDK (4.3.1) now. If you're still seeing issues after that, let us know ☺️

@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 22, 2024
@ibrahimchraibi
Copy link
Author

Thanks a lot for the quick fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants