From f35fce2bb9b1621e6da5cb66d69f235dfe345655 Mon Sep 17 00:00:00 2001 From: Vadorequest Date: Tue, 11 Apr 2023 16:18:10 +0200 Subject: [PATCH] Update Ubuntu from 18.04 to latest (currently 20.04) (#396) --- .github/workflows/auto-git-release.yml | 2 +- .../workflows/deploy-vercel-production.yml | 26 +++++++++---------- .github/workflows/deploy-vercel-staging.yml | 24 ++++++++--------- .github/workflows/deploy-vercel-storybook.yml | 16 ++++++------ .../workflows/update-codeclimate-coverage.yml | 4 +-- cypress/integration/app/common/footer.ts | 7 ++--- 6 files changed, 40 insertions(+), 39 deletions(-) diff --git a/.github/workflows/auto-git-release.yml b/.github/workflows/auto-git-release.yml index 47d587c69..9cd571c3c 100644 --- a/.github/workflows/auto-git-release.yml +++ b/.github/workflows/auto-git-release.yml @@ -17,7 +17,7 @@ on: jobs: tag-and-release: - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest timeout-minutes: 5 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: - name: Expose GitHub slug/short variables # See https://github.com/rlespinasse/github-slug-action#exposed-github-environment-variables diff --git a/.github/workflows/deploy-vercel-production.yml b/.github/workflows/deploy-vercel-production.yml index 88ed69328..04173d130 100644 --- a/.github/workflows/deploy-vercel-production.yml +++ b/.github/workflows/deploy-vercel-production.yml @@ -76,8 +76,8 @@ jobs: # Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs # Ex: Necessary to run `yarn deploy` setup-environment: - name: Setup deployment environment (Ubuntu 18.04 - Node 14.x) - runs-on: ubuntu-18.04 + name: Setup deployment environment (Ubuntu latest - Node 14.x) + runs-on: ubuntu-latest steps: - name: Installing node.js uses: actions/setup-node@v2 # Used to install node environment - https://github.com/actions/setup-node @@ -88,8 +88,8 @@ jobs: # The default customer is the one defined in the `vercel.json` file (which is a symlink to the actual file) # N.B: It's Vercel that will perform the actual deployment start-production-deployment: - name: Starts Vercel deployment (production) (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Starts Vercel deployment (production) (Ubuntu latest) + runs-on: ubuntu-latest needs: setup-environment timeout-minutes: 40 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: @@ -119,7 +119,7 @@ jobs: no_override: true # Disables auto marking previous environments as "inactive", as they're still active (Vercel deployments don't auto-deactivate) and it would remove the previous deployment links needlessly - name: Deploying on Vercel (${{ env.STAGE }}) - uses: UnlyEd/github-action-deploy-on-vercel@3e71d3e26fd56941fc24a6429fdd257598df2017 # Pin "v1.0.0" - See https://github.com/UnlyEd/github-action-deploy-on-vercel/commit/3e71d3e26fd56941fc24a6429fdd257598df2017 + uses: UnlyEd/github-action-deploy-on-vercel@94d41ec1ff9b5b1de5256312e385632b6fcd8fa4 # Pin "v1.2.1" - See https://github.com/UnlyEd/github-action-deploy-on-vercel/commit/94d41ec1ff9b5b1de5256312e385632b6fcd8fa4 with: command: "yarn deploy:ci:gha:production --token ${{ secrets.VERCEL_TOKEN }}" env: @@ -154,8 +154,8 @@ jobs: # Waits for the Vercel deployment to reach "READY" state, so that other actions will be applied on a domain that is really online await-for-vercel-deployment: - name: Await current deployment to be ready (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Await current deployment to be ready (Ubuntu latest) + runs-on: ubuntu-latest needs: start-production-deployment timeout-minutes: 5 # Limit current job timeout (including action timeout setup down there) https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: @@ -185,8 +185,8 @@ jobs: # Send a HTTP call to the webhook url that's provided in the customer configuration file (vercel.*.json) send-webhook-callback-once-deployment-ready: - name: Invoke webhook callback url defined by the customer (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Invoke webhook callback url defined by the customer (Ubuntu latest) + runs-on: ubuntu-latest needs: await-for-vercel-deployment timeout-minutes: 5 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: @@ -264,8 +264,8 @@ jobs: # Runs E2E tests against the Vercel deployment run-2e2-tests: - name: Run end to end (E2E) tests (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Run end to end (E2E) tests (Ubuntu latest) + runs-on: ubuntu-latest # Docker image with Cypress pre-installed # https://github.com/cypress-io/cypress-docker-images/tree/master/included container: cypress/included:7.4.0 @@ -314,8 +314,8 @@ jobs: # Runs LightHouse reports in parallel of E2E tests run-lighthouse-tests: - name: Run LightHouse checks (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Run LightHouse checks (Ubuntu latest) + runs-on: ubuntu-latest needs: await-for-vercel-deployment timeout-minutes: 5 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: diff --git a/.github/workflows/deploy-vercel-staging.yml b/.github/workflows/deploy-vercel-staging.yml index a72259ba0..97b9ea2d6 100644 --- a/.github/workflows/deploy-vercel-staging.yml +++ b/.github/workflows/deploy-vercel-staging.yml @@ -76,8 +76,8 @@ jobs: # Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs # Ex: Necessary to run `yarn deploy` setup-environment: - name: Setup deployment environment (Ubuntu 18.04 - Node 14.x) - runs-on: ubuntu-18.04 + name: Setup deployment environment (Ubuntu latest - Node 14.x) + runs-on: ubuntu-latest steps: - name: Installing node.js uses: actions/setup-node@v2 # Used to install node environment - https://github.com/actions/setup-node @@ -88,8 +88,8 @@ jobs: # The default customer is the one defined in the `vercel.json` file (which is a symlink to the actual file) # N.B: It's Vercel that will perform the actual deployment start-staging-deployment: - name: Starts Vercel deployment (staging) (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Starts Vercel deployment (staging) (Ubuntu latest) + runs-on: ubuntu-latest needs: setup-environment timeout-minutes: 40 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: @@ -202,8 +202,8 @@ jobs: # Waits for the Vercel deployment to reach "READY" state, so that other actions will be applied on a domain that is really online await-for-vercel-deployment: - name: Await current deployment to be ready (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Await current deployment to be ready (Ubuntu latest) + runs-on: ubuntu-latest needs: start-staging-deployment timeout-minutes: 5 # Limit current job timeout (including action timeout setup down there) https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: @@ -233,8 +233,8 @@ jobs: # Send a HTTP call to the webhook url that's provided in the customer configuration file (vercel.*.json) send-webhook-callback-once-deployment-ready: - name: Invoke webhook callback url defined by the customer (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Invoke webhook callback url defined by the customer (Ubuntu latest) + runs-on: ubuntu-latest needs: await-for-vercel-deployment timeout-minutes: 5 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: @@ -312,8 +312,8 @@ jobs: # Runs E2E tests against the Vercel deployment run-2e2-tests: - name: Run end to end (E2E) tests (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Run end to end (E2E) tests (Ubuntu latest) + runs-on: ubuntu-latest # Docker image with Cypress pre-installed # https://github.com/cypress-io/cypress-docker-images/tree/master/included container: cypress/included:7.4.0 @@ -386,8 +386,8 @@ jobs: # Runs LightHouse reports in parallel of E2E tests run-lighthouse-tests: - name: Run LightHouse checks (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Run LightHouse checks (Ubuntu latest) + runs-on: ubuntu-latest needs: await-for-vercel-deployment timeout-minutes: 5 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes steps: diff --git a/.github/workflows/deploy-vercel-storybook.yml b/.github/workflows/deploy-vercel-storybook.yml index 6236d9d9e..7852cf7b6 100644 --- a/.github/workflows/deploy-vercel-storybook.yml +++ b/.github/workflows/deploy-vercel-storybook.yml @@ -56,8 +56,8 @@ jobs: # Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs # Ex: Necessary to run `yarn deploy` setup-environment: - name: Setup deployment environment (Ubuntu 18.04 - Node 14.x) - runs-on: ubuntu-18.04 + name: Setup deployment environment (Ubuntu latest - Node 14.x) + runs-on: ubuntu-latest steps: - name: Installing node.js uses: actions/setup-node@v2 # Used to install node environment - https://github.com/actions/setup-node @@ -67,8 +67,8 @@ jobs: # Starts a Vercel deployment, using the storybook configuration file # N.B: It's Vercel that will perform the actual deployment start-deployment: - name: Starts Vercel deployment (Ubuntu 18.04) - runs-on: ubuntu-18.04 + name: Starts Vercel deployment (Ubuntu latest) + runs-on: ubuntu-latest timeout-minutes: 40 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes needs: setup-environment steps: @@ -155,9 +155,9 @@ jobs: # Waits for the Vercel deployment to reach "READY" state, so that other actions will be applied on a domain that is really online await-for-vercel-deployment: - name: Await current deployment to be ready (Ubuntu 18.04) + name: Await current deployment to be ready (Ubuntu latest) timeout-minutes: 5 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest needs: start-deployment steps: - uses: actions/checkout@v1 # Get last commit pushed - See https://github.com/actions/checkout @@ -186,9 +186,9 @@ jobs: # Runs E2E tests against the Vercel deployment run-2e2-tests: - name: Run end to end (E2E) tests (Ubuntu 18.04) + name: Run end to end (E2E) tests (Ubuntu latest) timeout-minutes: 20 # Limit current job timeout https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest # Docker image with Cypress pre-installed # https://github.com/cypress-io/cypress-docker-images/tree/master/included container: cypress/included:7.4.0 diff --git a/.github/workflows/update-codeclimate-coverage.yml b/.github/workflows/update-codeclimate-coverage.yml index 932772927..261fed320 100644 --- a/.github/workflows/update-codeclimate-coverage.yml +++ b/.github/workflows/update-codeclimate-coverage.yml @@ -18,8 +18,8 @@ jobs: # Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs # Ex: Necessary to run `yarn test:coverage` setup-environment: - name: Setup deployment environment (Ubuntu 18.04 - Node 14.x) - runs-on: ubuntu-18.04 + name: Setup deployment environment (Ubuntu latest - Node 14.x) + runs-on: ubuntu-latest steps: - name: Installing node.js uses: actions/setup-node@v2 # Used to install node environment - XXX https://github.com/actions/setup-node diff --git a/cypress/integration/app/common/footer.ts b/cypress/integration/app/common/footer.ts index 2d04ff9b4..598439487 100644 --- a/cypress/integration/app/common/footer.ts +++ b/cypress/integration/app/common/footer.ts @@ -21,9 +21,10 @@ describe('Common > Footer section', () => { cy.get('#footer-logo-unly-brand').should('have.length', 1); }); - it('should have the customer logo in the footer', () => { - cy.get('#footer-logo').should('have.length', 1); - }); + // Disabled because footer logo can be removed by anyone on the public demo and this makes tests crash for no valid reason (annoying) + // it('should have the customer logo in the footer', () => { + // cy.get('#footer-logo').should('have.length', 1); + // }); it('should display the i18n button to change language', () => { cy.get('@customer').then((customer: Customer) => {