Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 64-bit indices and large arrays #188

Merged
merged 1 commit into from
May 26, 2024

Conversation

gonzalobg
Copy link
Contributor

This PR adds support for 64-bit indices and large arrays. It is blocked on merging #186 .
Tested the following up to 141 GB of memory:

  • cuda
  • thrust
  • std-data/indices/ranges
  • omp
  • raja
  • tbb
  • ocl

The following fail, and I need to minimize and report a bug; this PR does not regress them for small sizes:

  • kokkos
  • acc

The following is not tested:

  • hip: @tom91136 it would be good to test it and test whether intptr_t or size_t is better for the indices (or no difference).
  • sycl

@gonzalobg gonzalobg force-pushed the large_index branch 4 times, most recently from 4f2c378 to 1022e79 Compare March 15, 2024 00:25
src/hip/HIPStream.cpp Outdated Show resolved Hide resolved
@tomdeakin tomdeakin mentioned this pull request May 13, 2024
18 tasks
@tomdeakin tomdeakin added this to the v6.0 milestone May 13, 2024
@gonzalobg
Copy link
Contributor Author

@tomdeakin @tom91136 This is blocked on #186, but is rebased on it now, and I've fixed the last thing that TomD requested, so should be ready once CI is green.

@tomdeakin
Copy link
Contributor

@gonzalobg - think this is good to merge now too, right?

@gonzalobg
Copy link
Contributor Author

Yes, I've rebased this on top of #186, and all tests also pass :)

@tomdeakin tomdeakin merged commit e1fffc0 into UoB-HPC:develop May 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants