-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Git support #9
base: main
Are you sure you want to change the base?
Conversation
I do not think there is any other option than making an instance on every prompt, many shells are quite slow due to this reason. And on the topic of plugins, it absolutely makes sense to give the end user a stock prompt in the beginning and they can add plugins one by one to add up to their likings, but until vshlang is not implemented I do not think that would be possible, shipping rust binaries would be redundant so I will be implementing piping, inbuilt commands proc macro first then move on to creating the language. |
I will review the code tomorrow, I don't think our time zones sync |
I would recommend making a utils folder, the files that I have in the |
Ok so i did what you said about file structures, tell me if it seems correct. I also added line of code modified visualization on the prompt but i think it's kinda superfluous. That's why i'm going to open a new pull request for runtime formatting (which might be related to a theme system) i will give more information on the pr description. |
in pub mod git;
pub mod highlight;
pub mod utils; rather than pub use {git::*, highlight::*, utils::*}; |
could you provide a screenshot of the prompt achieved with your new changes? |
sure I have a gitter account never used it much though, If you have discord I have it linked in my profile (vλimer9#0976) |
https://gitter.im/Vaimer9/vsh here's the gitter link for vsh |
What i want to implement:
.vshrc.toml
(might require a run time formatting library such asruntime-fmt
)Some observation regarding this pr: