-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
steam_helper: separate parameters from command when using ShellExecuteW #6555
steam_helper: separate parameters from command when using ShellExecuteW #6555
Conversation
3583441
to
d99d882
Compare
…otably in Northstar (PR ValveSoftware#6555)
…ments, notably in Northstar (PR ValveSoftware#6555)" This reverts commit 44549b7. This breaks Escape from Monkey Island and Memento Mori
been testing this for a while, unfortunately it breaks a few games: Guilty Gear Xrd |
d99d882
to
3ea790b
Compare
ShellExecuteW ignores any extra information passed as part of lpFile resulting in arguments being ignored.
rebased onto 8.0 and fixed the issue mentioned by GloriousEggroll tested using Guilty Gear Xrd REV 2 and Ultrakill to ensure nothing else broke. To go into more issue what caused this issue: I updated the |
3ea790b
to
00325dc
Compare
…ne arguements, notably in Northstar (PR ValveSoftware#6555)"" This reverts commit c09caf5. Restoring the patch because it has been updated with a fix for the previous problem.
Confirming everything working as expected now, thanks @Jan200101 |
@ivyl This seems ready for review, and according to the user is necessary for a Titanfall 2 mod (Northstar) to work. Would you mind taking a look? |
ShellExecuteW ignores any extra information passed as part of lpFile resulting in arguments being ignored. Link: #6555
6b9be33 merged, thanks! |
ShellExecuteW ignores any extra information passed as part of lpFile resulting in arguments being ignored. Link: #6555
ShellExecuteW ignores any extra information passed as part of lpFile resulting in arguments being ignored. Link: #6555
ShellExecuteW ignores any extra information passed as part of lpFile
resulting in arguments being ignored.