Treat GitHub Actions CI like travis/appveyor CI #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the current GitHub CI is that we do not know what instruction set the runners support.
test.cmake
has a detection mechanism for travis, but not for github actions, where it ran a simple CTest build (whatever that does, maybe testing what the host supports itself). On appveyor, a more complicated test setup is used, where CTest is invoked multiple times with different instruction sets, based on the environment variablesubset
. When the #278 was merged, the tests ran in a skylake CPU supporting all instruction sets. Current CI builds like #286 run on a broadwell CPU not supporting all instruction sets, which likely causes CTest to fail to enumerate the test suite.