Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New duplicate symbol handling breaks sig-gen during alias enumeration #18

Open
amtal opened this issue May 3, 2021 · 1 comment
Open

Comments

@amtal
Copy link

amtal commented May 3, 2021

Exception thrown due to using removed API: https://github.com/Vector35/sigkit/blob/master/compute_sig.py#L242

API commit removing Symbol.aliases property: Vector35/binaryninja-api@ccc46ee#diff-be75236b09e0ec25f6e7192bfcb0d69ef8467d6efa8bed2161108cf4e57559bc

Temp. workaround of info.aliases = [] #, proper fix ???

@bpotchik
Copy link
Member

bpotchik commented May 3, 2021

Looks like sigkit should probably be fixed. Replace func.symbol.aliases with:

func.view.get_symbols(func.symbol.address, 1)

Except it looks like info.aliases is expecting a list of strings and the code above will yield symbol objects. Just need to extract the name from each object as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants