Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update TypeScript Bindings #201

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

update TypeScript Bindings #201

wants to merge 5 commits into from

Conversation

arthurmilliken
Copy link
Contributor

No description provided.

@arthurmilliken arthurmilliken changed the title fix capitalization of readOnly normalize line endings, fix types/documentation for batch operations, fix typo in TxnOptions Mar 3, 2022
@Venemo
Copy link
Owner

Venemo commented Mar 3, 2022

Can you indicate in the commit messages that these only affect the TypeScript binding and not the rest of node-lmdb? Thanks.

@arthurmilliken arthurmilliken changed the title normalize line endings, fix types/documentation for batch operations, fix typo in TxnOptions update TypeScript Bindings Mar 3, 2022
@arthurmilliken
update TypeScript bindings only:
1a486b8 
- fix various typos
- normalize line endings to LF (Unix-style)
- fix types for batch operations (values must be Buffer objects)
@arthurmilliken
Copy link
Contributor Author

Can you indicate in the commit messages that these only affect the TypeScript binding and not the rest of node-lmdb? Thanks.

Done. I also squashed into a single commit for ease of reading.

@Llorx
Copy link

Llorx commented Apr 6, 2022

Also, the Env has a resize() and a info() methods that are not typed.

@arthurmilliken
Copy link
Contributor Author

Also, the Env has a resize() and a info() methods that are not typed.

Done. These are now included

@Pwndrian Pwndrian mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurmilliken @Venemo @Llorx