feat: add comment posting functionality by coverage action #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limbou
force-pushed
the
feat/add-coverage-pr-comment
branch
from
b54e6e1
to
3ec8dc1
Compare
Limbou
force-pushed
the
feat/add-coverage-pr-comment
branch
from
3ec8dc1
to
ce75489
Compare
Limbou
force-pushed
the
feat/add-coverage-pr-comment
branch
from
8763ddf
to
85f6943
Compare
Comment on lines
+120
to
+123
| const coverageMet = linesMissingCoverageByFile.length === 0; | ||
| const coverageStatus = coverageMet | ||
| ? `✅ Minimum coverage met` | ||
| : `❌ Minimum coverage treshold not met!`; |
There was a problem hiding this comment.
question: would this only be the case if the minimum coverage is 100? It seems like passing in isValidBuild into this function would be a safer way of setting this status
|
@Limbou any plans on picking this up again? I would really like this to be merged :) |
|
I'm closing due to inactivity, feel free to re-open 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add comment posting functionality for coverage action
You can see example bot comments here: https://github.com/Limbou/todo_app/pull/13
Closes #101
Type of Change