Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dart_package): allow run skipped tests #150

Closed
alestiago opened this issue Sep 28, 2023 · 1 comment · Fixed by #168
Closed

feat(dart_package): allow run skipped tests #150

alestiago opened this issue Sep 28, 2023 · 1 comment · Fixed by #168
Assignees
Labels
feature A new feature or request good first issue Good for newcomers

Comments

@alestiago
Copy link
Contributor

Description

As a developer I will sometimes have some tests that I skip locally but run in CI. The Dart CLI exposes a "run-skipped" parameter that allows doing so, however the dart_package doesn't use the parameter, see:

dart test -j ${{inputs.concurrency}} --coverage=coverage --platform=${{inputs.platform}} && dart pub global run coverage:format_coverage --lcov ${{(inputs.check_ignore && '--check-ignore') || ''}} --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=${{inputs.report_on}}

I would like to have a new parameter "run-skipped" that is set to false by default and can be enabled by the user.

The flutter_package workflow can also benefit of this change.

@kelvinwieth
Copy link
Contributor

Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants