Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Automatic Unicode toggle on pre-1.13 servers #511

Closed
Felix14-v2 opened this issue Aug 8, 2024 · 9 comments
Closed

[Feature request] Automatic Unicode toggle on pre-1.13 servers #511

Felix14-v2 opened this issue Aug 8, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@Felix14-v2
Copy link
Contributor

Felix14-v2 commented Aug 8, 2024

Problem Description

Minecraft 1.12.2 (and older versions) uses "thin" text style (at least in Russian language, other languages may also be affected) which is available by toggling Unicode in the language settings. Because of the difference between old and new font, all text formatting and styling is broken on pre-1.13 servers.

Solution Description

The easiest solution would be toggling Unicode automatically when connecting to a server with the affected version if affected language is detected on the client.

Alternatives

I don't think reimplementing the entire font system would be a good alternative.

Additional Info

Screenshots will be added later

@Felix14-v2 Felix14-v2 added the enhancement New feature or request label Aug 8, 2024
@Felix14-v2 Felix14-v2 changed the title Automatic Unicode toggle on pre-1.13 servers [Feature request] Automatic Unicode toggle on pre-1.13 servers Aug 8, 2024
@FlorianMichael
Copy link
Member

Thanks for the suggestion!
Implemented as "Force Unicode font for non-ASCII languages" in the visual category.

@Felix14-v2
Copy link
Contributor Author

Implemented as "Force Unicode font for non-ASCII languages" in the visual category

This will be disabled by default?

@FlorianMichael
Copy link
Member

I generally don't think servers should depend on the client having a specific font dimension, this breaks resourcepacks and is overall unsafe. Also unicode font looks worse than the normal one and users shouldn't be forced to it by default (assuming most servers don't depend on the client having unicode enabled)

@Felix14-v2
Copy link
Contributor Author

Felix14-v2 commented Aug 15, 2024

assuming most servers don't depend on the client having unicode enabled

The thing is that my language didn't have a "normal" font below 1.13, only the Unicode one. So all servers that still require a 1.12.2 (or an older) client assume that their clients only have the Unicode font

@FlorianMichael
Copy link
Member

I'm still against it because the server can't expect:

  • every user having the same language selected
  • no one to change the chat width in settings (in the example you provided on discord this would matter)
  • not having custom resourcepacks replacing the font installed

Furthermore not every server might depend on that and will break.

I could also imagine many people (especially russians) to use modern versions because the font rendering properly supports their language, unicode font is just worse imo.

I'm open for discussion but right now I see more arguments against it then for it, maybe other affected people can share their opinion.

@Felix14-v2
Copy link
Contributor Author

Felix14-v2 commented Aug 19, 2024

Furthermore not every server might depend on that and will break

Maybe then allow server-specific configuration?

@FlorianMichael
Copy link
Member

Why though? The setting is already included, the only thing is that someone who wants it has to enable it once and after that it will stay enabled

@Felix14-v2
Copy link
Contributor Author

As you said, not all old servers explicitly expect the old font, but the current approach enables it globally

@FlorianMichael
Copy link
Member

I see your point but I am still unsure if that's really needed, you are the first one even reporting this after over a year and it's not that hard to manually use Minecraft's option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants