From 5d0165003f4176d66231b331318054b2b7f744d9 Mon Sep 17 00:00:00 2001
From: Hendrik Iseke <39734979+hiseke@users.noreply.github.com>
Date: Tue, 23 Apr 2019 20:56:00 +0200
Subject: [PATCH] fix handling of gdpr object (#3756)

* initial orbidder version in personal github repo

* use adUnits from orbidder_example.html

* replace obsolete functions

* forgot to commit the test

* check if bidderRequest object is available

* try to fix weird safari/ie issue

* ebayK: add more params

* update orbidderBidAdapter.md

* use spec.<function> instead of this.<function> for consistency reasons

* add bidfloor parameter to params object

* fix gdpr object handling
---
 modules/orbidderBidAdapter.js                |  8 +--
 test/spec/modules/orbidderBidAdapter_spec.js | 57 ++++++++++----------
 2 files changed, 33 insertions(+), 32 deletions(-)

diff --git a/modules/orbidderBidAdapter.js b/modules/orbidderBidAdapter.js
index e316f3ef212..fc5eecbab08 100644
--- a/modules/orbidderBidAdapter.js
+++ b/modules/orbidderBidAdapter.js
@@ -42,11 +42,11 @@ export const spec = {
         }
       };
       spec.bidParams[bidRequest.bidId] = bidRequest.params;
-      if (bidRequest && bidRequest.gdprConsent) {
+      if (bidderRequest && bidderRequest.gdprConsent) {
         ret.data.gdprConsent = {
-          consentString: bidRequest.gdprConsent.consentString,
-          consentRequired: (typeof bidRequest.gdprConsent.gdprApplies === 'boolean')
-            ? bidRequest.gdprConsent.gdprApplies
+          consentString: bidderRequest.gdprConsent.consentString,
+          consentRequired: (typeof bidderRequest.gdprConsent.gdprApplies === 'boolean')
+            ? bidderRequest.gdprConsent.gdprApplies
             : true
         };
       }
diff --git a/test/spec/modules/orbidderBidAdapter_spec.js b/test/spec/modules/orbidderBidAdapter_spec.js
index 0761ed8d31e..bc88090095b 100644
--- a/test/spec/modules/orbidderBidAdapter_spec.js
+++ b/test/spec/modules/orbidderBidAdapter_spec.js
@@ -20,14 +20,17 @@ describe('orbidderBidAdapter', () => {
     return JSON.parse(JSON.stringify(val));
   };
 
-  const buildRequest = function (buildRequest) {
-    return spec.buildRequests(
-      [buildRequest],
-      {
-        refererInfo: {
-          referer: 'http://localhost:9876/'
-        }
-      })[0];
+  const buildRequest = (buildRequest, bidderRequest) => {
+    if (!Array.isArray(buildRequest)) {
+      buildRequest = [buildRequest];
+    }
+
+    return spec.buildRequests(buildRequest, {
+      ...bidderRequest || {},
+      refererInfo: {
+        referer: 'http://localhost:9876/'
+      }
+    })[0];
   };
 
   describe('inherited functions', () => {
@@ -101,30 +104,28 @@ describe('orbidderBidAdapter', () => {
     });
 
     it('handles empty gdpr object', () => {
-      const bidRequest = deepClone(defaultBidRequest);
-      bidRequest.gdprConsent = {};
-
-      const request = buildRequest(bidRequest);
+      const request = buildRequest(defaultBidRequest, {
+        gdprConsent: {}
+      });
       expect(request.data.gdprConsent.consentRequired).to.be.equal(true);
     });
 
     it('handles non-existent gdpr object', () => {
-      const bidRequest = deepClone(defaultBidRequest);
-      bidRequest.gdprConsent = null;
-
-      const request = buildRequest(bidRequest);
+      const request = buildRequest(defaultBidRequest, {
+        gdprConsent: null
+      });
       expect(request.data.gdprConsent).to.be.undefined;
     });
 
     it('handles properly filled gdpr object where gdpr applies', () => {
       const consentString = 'someWeirdString';
-      const bidRequest = deepClone(defaultBidRequest);
-      bidRequest.gdprConsent = {
-        gdprApplies: true,
-        consentString: 'someWeirdString'
-      };
+      const request = buildRequest(defaultBidRequest, {
+        gdprConsent: {
+          gdprApplies: true,
+          consentString: consentString
+        }
+      });
 
-      const request = buildRequest(bidRequest);
       const gdprConsent = request.data.gdprConsent;
       expect(gdprConsent.consentRequired).to.be.equal(true);
       expect(gdprConsent.consentString).to.be.equal(consentString);
@@ -132,13 +133,13 @@ describe('orbidderBidAdapter', () => {
 
     it('handles properly filled gdpr object where gdpr does not apply', () => {
       const consentString = 'someWeirdString';
-      const bidRequest = deepClone(defaultBidRequest);
-      bidRequest.gdprConsent = {
-        gdprApplies: false,
-        consentString: 'someWeirdString'
-      };
+      const request = buildRequest(defaultBidRequest, {
+        gdprConsent: {
+          gdprApplies: false,
+          consentString: consentString
+        }
+      });
 
-      const request = buildRequest(bidRequest);
       const gdprConsent = request.data.gdprConsent;
       expect(gdprConsent.consentRequired).to.be.equal(false);
       expect(gdprConsent.consentString).to.be.equal(consentString);