Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for https://github.com/nim-lang/Nim/pull/18050 scope based symbol resolution #125

Conversation

timotheecour
Copy link
Contributor

@Vindaar
Copy link
Owner

Vindaar commented Jul 7, 2021

Ah, thanks a lot. This is a left over from refactoring out some parts. Surprising that the code works in the first place though.

At the same time, this isn't an implicit (obv. not explicit) generic proc. Does the static argument have the same effect? I suppose it's similar as it also means there will be different instantiated procs.

@Vindaar Vindaar merged commit 3dca6f8 into Vindaar:master Jul 7, 2021
@timotheecour
Copy link
Contributor Author

Surprising that the code works in the first place though.

it won't after nim-lang/Nim#18050

this isn't an implicit (obv. not explicit) generic proc.

it's a generic proc because of the static param, eg:

proc fn(a: int, b: static bool = true) =
  static: echo ("instantiating fn", b)
fn(1)
fn(2, true)
fn(3, false)

prints:
("instantiating fn", true)
("instantiating fn", false)

@timotheecour timotheecour deleted the pr_ggplotnim_fix_sandwich_D20210519T113112 branch July 7, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants