Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RealisticNoise default values #199

Merged
merged 2 commits into from
Jul 19, 2022
Merged

RealisticNoise default values #199

merged 2 commits into from
Jul 19, 2022

Conversation

jsalotti
Copy link
Contributor

@jsalotti jsalotti commented Jul 15, 2022 •
edited
Loading

Do not merge before #200

  • Modified RealisticNoise default parameters to make it more realistic.
  • add default value same_on_sequence=False to be consistent with a real camera noise.

@jsalotti jsalotti marked this pull request as ready for review July 15, 2022 14:14
@jsalotti jsalotti requested a review from thibo73800 July 15, 2022 14:14
@thibo73800 thibo73800 requested a review from Data-Iab July 18, 2022 05:53
@jsalotti jsalotti self-assigned this Jul 18, 2022
@thibo73800 thibo73800 merged commit f11c566 into master Jul 19, 2022
@thibo73800 thibo73800 deleted the fix_realistic_noise branch July 19, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Data-Iab Data-Iab Data-Iab approved these changes

@thibo73800 thibo73800 Awaiting requested review from thibo73800

Assignees

@jsalotti jsalotti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsalotti @Data-Iab @thibo73800